From: John Einar Reitan <john.reitan@foss.arm.com>
To: Colin Cross <ccross@google.com>
Cc: "Laura Abbott" <labbott@redhat.com>,
"Greg KH" <gregkh@linuxfoundation.org>,
"Arve Hjønnevåg" <arve@android.com>,
"devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ion: scatterlist offset not used for buffer map
Date: Mon, 11 Apr 2016 09:10:10 +0200 [thread overview]
Message-ID: <20160411071010.GA25871@e106921-lin.trondheim.arm.com> (raw)
In-Reply-To: <CAMbhsRTOpdjG8yShpFUvC3=aswLbFY8p7Q2Cab7pBh+2smY=+Q@mail.gmail.com>
> I don't think this is right. A compound_page still has a page struct
> for every page, you should be passing the page struct where your data
> starts. Using an offset > PAGE_SIZE is going to break lots of places,
> for example anywhere that uses kmap(sg_page(sg)).
Was kind-of expecting that response. Will update, thanks.
prev parent reply other threads:[~2016-04-11 7:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-07 11:29 [PATCH] ion: scatterlist offset not used for buffer map John Einar Reitan
2016-04-07 19:37 ` Laura Abbott
2016-04-08 6:56 ` John Einar Reitan
2016-04-08 22:43 ` Laura Abbott
2016-04-08 23:11 ` Colin Cross
2016-04-11 7:10 ` John Einar Reitan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160411071010.GA25871@e106921-lin.trondheim.arm.com \
--to=john.reitan@foss.arm.com \
--cc=arve@android.com \
--cc=ccross@google.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=labbott@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).