From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752597AbcDKIAi (ORCPT ); Mon, 11 Apr 2016 04:00:38 -0400 Received: from mail-wm0-f41.google.com ([74.125.82.41]:33476 "EHLO mail-wm0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752396AbcDKIAf (ORCPT ); Mon, 11 Apr 2016 04:00:35 -0400 Date: Mon, 11 Apr 2016 09:00:30 +0100 From: Lee Jones To: Krzysztof Kozlowski Cc: Chanwoo Choi , Arnd Bergmann , Javier Martinez Canillas , Kukjin Kim , Olof Johansson , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, Kevin Hilman , Paul Gortmaker Subject: Re: [PATCH 1/2] mfd: max77693: Allow building as a module Message-ID: <20160411080030.GB4592@x1> References: <1459756459-22061-1-git-send-email-k.kozlowski@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1459756459-22061-1-git-send-email-k.kozlowski@samsung.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 04 Apr 2016, Krzysztof Kozlowski wrote: > The consumer of max77693 regulators on Trats2 board (samsung-usb2-phy > driver) supports deferred probing so the max77693 main MFD driver can be > built now as a module. This gives more flexibility and removes manual > ordering of init calls. > > Suggested-by: Paul Gortmaker > Cc: Paul Gortmaker > Signed-off-by: Krzysztof Kozlowski > --- > drivers/mfd/Kconfig | 4 ++-- > drivers/mfd/max77693.c | 14 ++------------ > 2 files changed, 4 insertions(+), 14 deletions(-) Applied, thanks. > diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig > index eea61e349e26..aa1e7c3f82ee 100644 > --- a/drivers/mfd/Kconfig > +++ b/drivers/mfd/Kconfig > @@ -543,8 +543,8 @@ config MFD_MAX77686 > of the device. > > config MFD_MAX77693 > - bool "Maxim Semiconductor MAX77693 PMIC Support" > - depends on I2C=y > + tristate "Maxim Semiconductor MAX77693 PMIC Support" > + depends on I2C > select MFD_CORE > select REGMAP_I2C > select REGMAP_IRQ > diff --git a/drivers/mfd/max77693.c b/drivers/mfd/max77693.c > index b83b7a7da1ae..78e501feb96c 100644 > --- a/drivers/mfd/max77693.c > +++ b/drivers/mfd/max77693.c > @@ -368,6 +368,7 @@ static const struct of_device_id max77693_dt_match[] = { > { .compatible = "maxim,max77693" }, > {}, > }; > +MODULE_DEVICE_TABLE(of, max77693_dt_match); > #endif > > static struct i2c_driver max77693_i2c_driver = { > @@ -381,18 +382,7 @@ static struct i2c_driver max77693_i2c_driver = { > .id_table = max77693_i2c_id, > }; > > -static int __init max77693_i2c_init(void) > -{ > - return i2c_add_driver(&max77693_i2c_driver); > -} > -/* init early so consumer devices can complete system boot */ > -subsys_initcall(max77693_i2c_init); > - > -static void __exit max77693_i2c_exit(void) > -{ > - i2c_del_driver(&max77693_i2c_driver); > -} > -module_exit(max77693_i2c_exit); > +module_i2c_driver(max77693_i2c_driver); > > MODULE_DESCRIPTION("MAXIM 77693 multi-function core driver"); > MODULE_AUTHOR("SangYoung, Son "); -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog