From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753174AbcDKJPq (ORCPT ); Mon, 11 Apr 2016 05:15:46 -0400 Received: from mail-wm0-f53.google.com ([74.125.82.53]:35421 "EHLO mail-wm0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750971AbcDKJPn (ORCPT ); Mon, 11 Apr 2016 05:15:43 -0400 Date: Mon, 11 Apr 2016 10:15:39 +0100 From: Lee Jones To: Laxman Dewangan Cc: corbet@lwn.net, andreas.werner@men.de, tony@atomide.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, patches@opensource.wolfsonmicro.com, Boris Brezillon Subject: Re: [PATCH V2 05/20] mfd: atmel-hlcdc: Use devm_mfd_add_devices() for mfd_device registration Message-ID: <20160411091539.GS4592@x1> References: <1460054594-32325-1-git-send-email-ldewangan@nvidia.com> <1460054594-32325-6-git-send-email-ldewangan@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1460054594-32325-6-git-send-email-ldewangan@nvidia.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Applied, thanks. On Fri, 08 Apr 2016, Laxman Dewangan wrote: > Use devm_mfd_add_devices() for MFD devices registration and get > rid of .remove callback to remove MFD child-devices. This is done > by managed device framework. > > Signed-off-by: Laxman Dewangan > CC: Boris Brezillon > Acked-by: Boris Brezillon > > --- > Changes from V1: > - Convert mfd to MFD. > - Run checkpatch with --strict option and fix warning. > - Collected acks. > > drivers/mfd/atmel-hlcdc.c | 14 +++----------- > 1 file changed, 3 insertions(+), 11 deletions(-) > > diff --git a/drivers/mfd/atmel-hlcdc.c b/drivers/mfd/atmel-hlcdc.c > index 06c2058..eca7ea6 100644 > --- a/drivers/mfd/atmel-hlcdc.c > +++ b/drivers/mfd/atmel-hlcdc.c > @@ -128,16 +128,9 @@ static int atmel_hlcdc_probe(struct platform_device *pdev) > > dev_set_drvdata(dev, hlcdc); > > - return mfd_add_devices(dev, -1, atmel_hlcdc_cells, > - ARRAY_SIZE(atmel_hlcdc_cells), > - NULL, 0, NULL); > -} > - > -static int atmel_hlcdc_remove(struct platform_device *pdev) > -{ > - mfd_remove_devices(&pdev->dev); > - > - return 0; > + return devm_mfd_add_devices(dev, -1, atmel_hlcdc_cells, > + ARRAY_SIZE(atmel_hlcdc_cells), > + NULL, 0, NULL); > } > > static const struct of_device_id atmel_hlcdc_match[] = { > @@ -152,7 +145,6 @@ MODULE_DEVICE_TABLE(of, atmel_hlcdc_match); > > static struct platform_driver atmel_hlcdc_driver = { > .probe = atmel_hlcdc_probe, > - .remove = atmel_hlcdc_remove, > .driver = { > .name = "atmel-hlcdc", > .of_match_table = atmel_hlcdc_match, -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog