From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753281AbcDKJPx (ORCPT ); Mon, 11 Apr 2016 05:15:53 -0400 Received: from mail-wm0-f43.google.com ([74.125.82.43]:36187 "EHLO mail-wm0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753183AbcDKJPu (ORCPT ); Mon, 11 Apr 2016 05:15:50 -0400 Date: Mon, 11 Apr 2016 10:15:46 +0100 From: Lee Jones To: Laxman Dewangan Cc: corbet@lwn.net, andreas.werner@men.de, tony@atomide.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, patches@opensource.wolfsonmicro.com, Matt Porter Subject: Re: [PATCH V2 06/20] mfd: bcm590xx: Use devm_mfd_add_devices() for mfd_device registration Message-ID: <20160411091546.GT4592@x1> References: <1460054594-32325-1-git-send-email-ldewangan@nvidia.com> <1460054594-32325-7-git-send-email-ldewangan@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1460054594-32325-7-git-send-email-ldewangan@nvidia.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Applied, thanks. On Fri, 08 Apr 2016, Laxman Dewangan wrote: > Use devm_mfd_add_devices() for MFD devices registration and get > rid of .remove callback to remove MFD child-devices. This is done > by managed device framework. > > Signed-off-by: Laxman Dewangan > CC: Matt Porter > > --- > Changes from V1: > - Convert mfd to MFD. > - Run checkpatch with --strict option and fix warning. > > drivers/mfd/bcm590xx.c | 11 ++--------- > 1 file changed, 2 insertions(+), 9 deletions(-) > > diff --git a/drivers/mfd/bcm590xx.c b/drivers/mfd/bcm590xx.c > index 320aaef..0d76d69 100644 > --- a/drivers/mfd/bcm590xx.c > +++ b/drivers/mfd/bcm590xx.c > @@ -82,8 +82,8 @@ static int bcm590xx_i2c_probe(struct i2c_client *i2c_pri, > goto err; > } > > - ret = mfd_add_devices(&i2c_pri->dev, -1, bcm590xx_devs, > - ARRAY_SIZE(bcm590xx_devs), NULL, 0, NULL); > + ret = devm_mfd_add_devices(&i2c_pri->dev, -1, bcm590xx_devs, > + ARRAY_SIZE(bcm590xx_devs), NULL, 0, NULL); > if (ret < 0) { > dev_err(&i2c_pri->dev, "failed to add sub-devices: %d\n", ret); > goto err; > @@ -96,12 +96,6 @@ err: > return ret; > } > > -static int bcm590xx_i2c_remove(struct i2c_client *i2c) > -{ > - mfd_remove_devices(&i2c->dev); > - return 0; > -} > - > static const struct of_device_id bcm590xx_of_match[] = { > { .compatible = "brcm,bcm59056" }, > { } > @@ -120,7 +114,6 @@ static struct i2c_driver bcm590xx_i2c_driver = { > .of_match_table = of_match_ptr(bcm590xx_of_match), > }, > .probe = bcm590xx_i2c_probe, > - .remove = bcm590xx_i2c_remove, > .id_table = bcm590xx_i2c_id, > }; > module_i2c_driver(bcm590xx_i2c_driver); -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog