From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753432AbcDKJQI (ORCPT ); Mon, 11 Apr 2016 05:16:08 -0400 Received: from mail-wm0-f47.google.com ([74.125.82.47]:33840 "EHLO mail-wm0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752838AbcDKJQE (ORCPT ); Mon, 11 Apr 2016 05:16:04 -0400 Date: Mon, 11 Apr 2016 10:15:54 +0100 From: Lee Jones To: Laxman Dewangan Cc: corbet@lwn.net, andreas.werner@men.de, tony@atomide.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, patches@opensource.wolfsonmicro.com, Guodong Xu Subject: Re: [PATCH V2 07/20] mfd: hi6421-pmic: Use devm_mfd_add_devices() for mfd_device registration Message-ID: <20160411091554.GU4592@x1> References: <1460054594-32325-1-git-send-email-ldewangan@nvidia.com> <1460054594-32325-8-git-send-email-ldewangan@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1460054594-32325-8-git-send-email-ldewangan@nvidia.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Applied, thanks. On Fri, 08 Apr 2016, Laxman Dewangan wrote: > Use devm_mfd_add_devices() for MFD devices registration and get > rid of .remove callback to remove MFD child-devices. This is done > by managed device framework. > > Signed-off-by: Laxman Dewangan > CC: Guodong Xu > > --- > Changes from V1: > - Convert mfd to MFD. > - Run checkpatch with --strict option and fix warning. > > drivers/mfd/hi6421-pmic-core.c | 12 ++---------- > 1 file changed, 2 insertions(+), 10 deletions(-) > > diff --git a/drivers/mfd/hi6421-pmic-core.c b/drivers/mfd/hi6421-pmic-core.c > index f9ded45..3fd703f 100644 > --- a/drivers/mfd/hi6421-pmic-core.c > +++ b/drivers/mfd/hi6421-pmic-core.c > @@ -76,8 +76,8 @@ static int hi6421_pmic_probe(struct platform_device *pdev) > > platform_set_drvdata(pdev, pmic); > > - ret = mfd_add_devices(&pdev->dev, 0, hi6421_devs, > - ARRAY_SIZE(hi6421_devs), NULL, 0, NULL); > + ret = devm_mfd_add_devices(&pdev->dev, 0, hi6421_devs, > + ARRAY_SIZE(hi6421_devs), NULL, 0, NULL); > if (ret) { > dev_err(&pdev->dev, "add mfd devices failed: %d\n", ret); > return ret; > @@ -86,13 +86,6 @@ static int hi6421_pmic_probe(struct platform_device *pdev) > return 0; > } > > -static int hi6421_pmic_remove(struct platform_device *pdev) > -{ > - mfd_remove_devices(&pdev->dev); > - > - return 0; > -} > - > static const struct of_device_id of_hi6421_pmic_match_tbl[] = { > { .compatible = "hisilicon,hi6421-pmic", }, > { }, > @@ -105,7 +98,6 @@ static struct platform_driver hi6421_pmic_driver = { > .of_match_table = of_hi6421_pmic_match_tbl, > }, > .probe = hi6421_pmic_probe, > - .remove = hi6421_pmic_remove, > }; > module_platform_driver(hi6421_pmic_driver); > -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog