From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753721AbcDKJb1 (ORCPT ); Mon, 11 Apr 2016 05:31:27 -0400 Received: from mail-wm0-f46.google.com ([74.125.82.46]:36558 "EHLO mail-wm0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752707AbcDKJbZ (ORCPT ); Mon, 11 Apr 2016 05:31:25 -0400 Date: Mon, 11 Apr 2016 10:31:20 +0100 From: Lee Jones To: Laxman Dewangan Cc: corbet@lwn.net, andreas.werner@men.de, tony@atomide.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, patches@opensource.wolfsonmicro.com, Florian Fainelli Subject: Re: [PATCH V2 11/20] mfd: rdc321x: Use devm_mfd_add_devices() for mfd_device registration Message-ID: <20160411093120.GB7994@x1> References: <1460054594-32325-1-git-send-email-ldewangan@nvidia.com> <1460054594-32325-12-git-send-email-ldewangan@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1460054594-32325-12-git-send-email-ldewangan@nvidia.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Applied, thanks. On Fri, 08 Apr 2016, Laxman Dewangan wrote: > Use devm_mfd_add_devices() for MFD devices registration and get > rid of .remove callback to remove MFD child-devices. This is done > by managed device framework. > > Signed-off-by: Laxman Dewangan > CC: Florian Fainelli > > --- > Changes from V1: > - Convert mfd to MFD. > - Fix checkpatch --strict error on patch. > > drivers/mfd/rdc321x-southbridge.c | 13 ++++--------- > 1 file changed, 4 insertions(+), 9 deletions(-) > > diff --git a/drivers/mfd/rdc321x-southbridge.c b/drivers/mfd/rdc321x-southbridge.c > index 6575585..2bd8c5b 100644 > --- a/drivers/mfd/rdc321x-southbridge.c > +++ b/drivers/mfd/rdc321x-southbridge.c > @@ -85,14 +85,10 @@ static int rdc321x_sb_probe(struct pci_dev *pdev, > rdc321x_gpio_pdata.sb_pdev = pdev; > rdc321x_wdt_pdata.sb_pdev = pdev; > > - return mfd_add_devices(&pdev->dev, -1, > - rdc321x_sb_cells, ARRAY_SIZE(rdc321x_sb_cells), > - NULL, 0, NULL); > -} > - > -static void rdc321x_sb_remove(struct pci_dev *pdev) > -{ > - mfd_remove_devices(&pdev->dev); > + return devm_mfd_add_devices(&pdev->dev, -1, > + rdc321x_sb_cells, > + ARRAY_SIZE(rdc321x_sb_cells), > + NULL, 0, NULL); > } > > static const struct pci_device_id rdc321x_sb_table[] = { > @@ -105,7 +101,6 @@ static struct pci_driver rdc321x_sb_driver = { > .name = "RDC321x Southbridge", > .id_table = rdc321x_sb_table, > .probe = rdc321x_sb_probe, > - .remove = rdc321x_sb_remove, > }; > > module_pci_driver(rdc321x_sb_driver); -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog