From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753983AbcDKJbz (ORCPT ); Mon, 11 Apr 2016 05:31:55 -0400 Received: from mail-wm0-f47.google.com ([74.125.82.47]:36003 "EHLO mail-wm0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753293AbcDKJbx (ORCPT ); Mon, 11 Apr 2016 05:31:53 -0400 Date: Mon, 11 Apr 2016 10:31:49 +0100 From: Lee Jones To: Laxman Dewangan Cc: corbet@lwn.net, andreas.werner@men.de, tony@atomide.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, patches@opensource.wolfsonmicro.com, Ingi Kim , Javier Martinez Canillas Subject: Re: [PATCH V2 14/20] mfd: rt5033: Use devm_mfd_add_devices() for mfd_device registration Message-ID: <20160411093149.GE7994@x1> References: <1460054594-32325-1-git-send-email-ldewangan@nvidia.com> <1460054594-32325-15-git-send-email-ldewangan@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1460054594-32325-15-git-send-email-ldewangan@nvidia.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Applied, thanks. On Fri, 08 Apr 2016, Laxman Dewangan wrote: > Use devm_mfd_add_devices() for MFD devices registration and get > rid of .remove callback to remove MFD child-devices. This is done > by managed device framework. > > Signed-off-by: Laxman Dewangan > CC: Ingi Kim > CC: Javier Martinez Canillas > Reviewed-by: Javier Martinez Canillas > > --- > Changes from V1: > - Convert mfd to MFD. > - Run checkpatch with --strict option and fix warning. > - Collected reviewed by. > > drivers/mfd/rt5033.c | 14 +++----------- > 1 file changed, 3 insertions(+), 11 deletions(-) > > diff --git a/drivers/mfd/rt5033.c b/drivers/mfd/rt5033.c > index 2b95485..9bd089c 100644 > --- a/drivers/mfd/rt5033.c > +++ b/drivers/mfd/rt5033.c > @@ -97,9 +97,9 @@ static int rt5033_i2c_probe(struct i2c_client *i2c, > return ret; > } > > - ret = mfd_add_devices(rt5033->dev, -1, rt5033_devs, > - ARRAY_SIZE(rt5033_devs), NULL, 0, > - regmap_irq_get_domain(rt5033->irq_data)); > + ret = devm_mfd_add_devices(rt5033->dev, -1, rt5033_devs, > + ARRAY_SIZE(rt5033_devs), NULL, 0, > + regmap_irq_get_domain(rt5033->irq_data)); > if (ret < 0) { > dev_err(&i2c->dev, "Failed to add RT5033 child devices.\n"); > return ret; > @@ -110,13 +110,6 @@ static int rt5033_i2c_probe(struct i2c_client *i2c, > return 0; > } > > -static int rt5033_i2c_remove(struct i2c_client *i2c) > -{ > - mfd_remove_devices(&i2c->dev); > - > - return 0; > -} > - > static const struct i2c_device_id rt5033_i2c_id[] = { > { "rt5033", }, > { } > @@ -135,7 +128,6 @@ static struct i2c_driver rt5033_driver = { > .of_match_table = of_match_ptr(rt5033_dt_match), > }, > .probe = rt5033_i2c_probe, > - .remove = rt5033_i2c_remove, > .id_table = rt5033_i2c_id, > }; > module_i2c_driver(rt5033_driver); -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog