From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754033AbcDKJcJ (ORCPT ); Mon, 11 Apr 2016 05:32:09 -0400 Received: from mail-wm0-f51.google.com ([74.125.82.51]:37275 "EHLO mail-wm0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753998AbcDKJcG (ORCPT ); Mon, 11 Apr 2016 05:32:06 -0400 Date: Mon, 11 Apr 2016 10:31:56 +0100 From: Lee Jones To: Laxman Dewangan Cc: corbet@lwn.net, andreas.werner@men.de, tony@atomide.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, patches@opensource.wolfsonmicro.com, Gyungoh Yoo Subject: Re: [PATCH V2 15/20] mfd: sky81452: Use devm_mfd_add_devices() for mfd_device registration Message-ID: <20160411093156.GF7994@x1> References: <1460054594-32325-1-git-send-email-ldewangan@nvidia.com> <1460054594-32325-16-git-send-email-ldewangan@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1460054594-32325-16-git-send-email-ldewangan@nvidia.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Applied, thanks. On Fri, 08 Apr 2016, Laxman Dewangan wrote: > Use devm_mfd_add_devices() for MFD devices registration and get > rid of .remove callback to remove MFD child-devices. This is done > by managed device framework. > > Signed-off-by: Laxman Dewangan > CC: Gyungoh Yoo > > --- > Changes from V1: > - Convert mfd to MFD. > - Run checkpatch with --strict option and fix warning. > > drivers/mfd/sky81452.c | 10 ++-------- > 1 file changed, 2 insertions(+), 8 deletions(-) > > diff --git a/drivers/mfd/sky81452.c b/drivers/mfd/sky81452.c > index b0c9b04..30a2a67 100644 > --- a/drivers/mfd/sky81452.c > +++ b/drivers/mfd/sky81452.c > @@ -64,19 +64,14 @@ static int sky81452_probe(struct i2c_client *client, > cells[1].platform_data = pdata->regulator_init_data; > cells[1].pdata_size = sizeof(*pdata->regulator_init_data); > > - ret = mfd_add_devices(dev, -1, cells, ARRAY_SIZE(cells), NULL, 0, NULL); > + ret = devm_mfd_add_devices(dev, -1, cells, ARRAY_SIZE(cells), > + NULL, 0, NULL); > if (ret) > dev_err(dev, "failed to add child devices. err=%d\n", ret); > > return ret; > } > > -static int sky81452_remove(struct i2c_client *client) > -{ > - mfd_remove_devices(&client->dev); > - return 0; > -} > - > static const struct i2c_device_id sky81452_ids[] = { > { "sky81452" }, > { } > @@ -97,7 +92,6 @@ static struct i2c_driver sky81452_driver = { > .of_match_table = of_match_ptr(sky81452_of_match), > }, > .probe = sky81452_probe, > - .remove = sky81452_remove, > .id_table = sky81452_ids, > }; > -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog