From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754050AbcDKJcN (ORCPT ); Mon, 11 Apr 2016 05:32:13 -0400 Received: from mail-wm0-f43.google.com ([74.125.82.43]:37435 "EHLO mail-wm0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753998AbcDKJcJ (ORCPT ); Mon, 11 Apr 2016 05:32:09 -0400 Date: Mon, 11 Apr 2016 10:32:05 +0100 From: Lee Jones To: Laxman Dewangan Cc: corbet@lwn.net, andreas.werner@men.de, tony@atomide.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, patches@opensource.wolfsonmicro.com, Linus Walleij Subject: Re: [PATCH V2 16/20] mfd: stw481x: Use devm_mfd_add_devices() for mfd_device registration Message-ID: <20160411093205.GG7994@x1> References: <1460054594-32325-1-git-send-email-ldewangan@nvidia.com> <1460054594-32325-17-git-send-email-ldewangan@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1460054594-32325-17-git-send-email-ldewangan@nvidia.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Applied, thanks. On Fri, 08 Apr 2016, Laxman Dewangan wrote: > Use devm_mfd_add_devices() for MFD devices registration and get > rid of .remove callback to remove MFD child-devices. This is done > by managed device framework. > > Signed-off-by: Laxman Dewangan > CC: Linus Walleij > Acked-by: Linus Walleij > > --- > Changes from V1: > - Convert mfd to MFD. > - Run checkpatch with --strict option and fix warning. > - Collected acks. > > drivers/mfd/stw481x.c | 11 ++--------- > 1 file changed, 2 insertions(+), 9 deletions(-) > > diff --git a/drivers/mfd/stw481x.c b/drivers/mfd/stw481x.c > index ca613df..ab949ea 100644 > --- a/drivers/mfd/stw481x.c > +++ b/drivers/mfd/stw481x.c > @@ -206,8 +206,8 @@ static int stw481x_probe(struct i2c_client *client, > stw481x_cells[i].pdata_size = sizeof(*stw481x); > } > > - ret = mfd_add_devices(&client->dev, 0, stw481x_cells, > - ARRAY_SIZE(stw481x_cells), NULL, 0, NULL); > + ret = devm_mfd_add_devices(&client->dev, 0, stw481x_cells, > + ARRAY_SIZE(stw481x_cells), NULL, 0, NULL); > if (ret) > return ret; > > @@ -216,12 +216,6 @@ static int stw481x_probe(struct i2c_client *client, > return ret; > } > > -static int stw481x_remove(struct i2c_client *client) > -{ > - mfd_remove_devices(&client->dev); > - return 0; > -} > - > /* > * This ID table is completely unused, as this is a pure > * device-tree probed driver, but it has to be here due to > @@ -246,7 +240,6 @@ static struct i2c_driver stw481x_driver = { > .of_match_table = stw481x_match, > }, > .probe = stw481x_probe, > - .remove = stw481x_remove, > .id_table = stw481x_id, > }; > -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog