From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754111AbcDKJcb (ORCPT ); Mon, 11 Apr 2016 05:32:31 -0400 Received: from mail-wm0-f51.google.com ([74.125.82.51]:36436 "EHLO mail-wm0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753399AbcDKJc2 (ORCPT ); Mon, 11 Apr 2016 05:32:28 -0400 Date: Mon, 11 Apr 2016 10:32:14 +0100 From: Lee Jones To: Laxman Dewangan Cc: corbet@lwn.net, andreas.werner@men.de, tony@atomide.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, patches@opensource.wolfsonmicro.com, Todd Fischer Subject: Re: [PATCH V2 17/20] mfd: tps6507x: Use devm_mfd_add_devices() for mfd_device registration Message-ID: <20160411093214.GH7994@x1> References: <1460054594-32325-1-git-send-email-ldewangan@nvidia.com> <1460054594-32325-18-git-send-email-ldewangan@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1460054594-32325-18-git-send-email-ldewangan@nvidia.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Applied, thanks. On Fri, 08 Apr 2016, Laxman Dewangan wrote: > Use devm_mfd_add_devices() for MFD devices registration and get > rid of .remove callback to remove MFD child-devices. This is done > by managed device framework. > > Signed-off-by: Laxman Dewangan > CC: Todd Fischer > > --- > Changes from V1: > - Convert mfd to MFD. > - Fix checkpatch --strict error on patch. > > drivers/mfd/tps6507x.c | 13 ++----------- > 1 file changed, 2 insertions(+), 11 deletions(-) > > diff --git a/drivers/mfd/tps6507x.c b/drivers/mfd/tps6507x.c > index 1ab3dd6..40beb2f 100644 > --- a/drivers/mfd/tps6507x.c > +++ b/drivers/mfd/tps6507x.c > @@ -100,16 +100,8 @@ static int tps6507x_i2c_probe(struct i2c_client *i2c, > tps6507x->read_dev = tps6507x_i2c_read_device; > tps6507x->write_dev = tps6507x_i2c_write_device; > > - return mfd_add_devices(tps6507x->dev, -1, tps6507x_devs, > - ARRAY_SIZE(tps6507x_devs), NULL, 0, NULL); > -} > - > -static int tps6507x_i2c_remove(struct i2c_client *i2c) > -{ > - struct tps6507x_dev *tps6507x = i2c_get_clientdata(i2c); > - > - mfd_remove_devices(tps6507x->dev); > - return 0; > + return devm_mfd_add_devices(tps6507x->dev, -1, tps6507x_devs, > + ARRAY_SIZE(tps6507x_devs), NULL, 0, NULL); > } > > static const struct i2c_device_id tps6507x_i2c_id[] = { > @@ -132,7 +124,6 @@ static struct i2c_driver tps6507x_i2c_driver = { > .of_match_table = of_match_ptr(tps6507x_of_match), > }, > .probe = tps6507x_i2c_probe, > - .remove = tps6507x_i2c_remove, > .id_table = tps6507x_i2c_id, > }; > -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog