From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754169AbcDKJdG (ORCPT ); Mon, 11 Apr 2016 05:33:06 -0400 Received: from mail-wm0-f46.google.com ([74.125.82.46]:34921 "EHLO mail-wm0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754117AbcDKJcg (ORCPT ); Mon, 11 Apr 2016 05:32:36 -0400 Date: Mon, 11 Apr 2016 10:32:22 +0100 From: Lee Jones To: Laxman Dewangan Cc: corbet@lwn.net, andreas.werner@men.de, tony@atomide.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, patches@opensource.wolfsonmicro.com Subject: Re: [PATCH V2 18/20] mfd: tps65217: Use devm_mfd_add_devices() for mfd_device registration Message-ID: <20160411093222.GI7994@x1> References: <1460054594-32325-1-git-send-email-ldewangan@nvidia.com> <1460054594-32325-19-git-send-email-ldewangan@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1460054594-32325-19-git-send-email-ldewangan@nvidia.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Applied, thanks. On Fri, 08 Apr 2016, Laxman Dewangan wrote: > Use devm_mfd_add_devices() for MFD devices registration and get > rid of .remove callback to remove MFD child-devices. This is done > by managed device framework. > > Signed-off-by: Laxman Dewangan > CC: Tony Lindgren > > --- > Changes from V1: > - Convert mfd to MFD. > - Run checkpatch with --strict option and fix warning. > > drivers/mfd/tps65217.c | 14 ++------------ > 1 file changed, 2 insertions(+), 12 deletions(-) > > diff --git a/drivers/mfd/tps65217.c b/drivers/mfd/tps65217.c > index d32b5442..049a6fc 100644 > --- a/drivers/mfd/tps65217.c > +++ b/drivers/mfd/tps65217.c > @@ -205,8 +205,8 @@ static int tps65217_probe(struct i2c_client *client, > return ret; > } > > - ret = mfd_add_devices(tps->dev, -1, tps65217s, > - ARRAY_SIZE(tps65217s), NULL, 0, NULL); > + ret = devm_mfd_add_devices(tps->dev, -1, tps65217s, > + ARRAY_SIZE(tps65217s), NULL, 0, NULL); > if (ret < 0) { > dev_err(tps->dev, "mfd_add_devices failed: %d\n", ret); > return ret; > @@ -235,15 +235,6 @@ static int tps65217_probe(struct i2c_client *client, > return 0; > } > > -static int tps65217_remove(struct i2c_client *client) > -{ > - struct tps65217 *tps = i2c_get_clientdata(client); > - > - mfd_remove_devices(tps->dev); > - > - return 0; > -} > - > static const struct i2c_device_id tps65217_id_table[] = { > {"tps65217", TPS65217}, > { /* sentinel */ } > @@ -257,7 +248,6 @@ static struct i2c_driver tps65217_driver = { > }, > .id_table = tps65217_id_table, > .probe = tps65217_probe, > - .remove = tps65217_remove, > }; > > static int __init tps65217_init(void) -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog