From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754141AbcDKJcj (ORCPT ); Mon, 11 Apr 2016 05:32:39 -0400 Received: from mail-wm0-f44.google.com ([74.125.82.44]:33455 "EHLO mail-wm0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754116AbcDKJcg (ORCPT ); Mon, 11 Apr 2016 05:32:36 -0400 Date: Mon, 11 Apr 2016 10:32:31 +0100 From: Lee Jones To: Laxman Dewangan Cc: corbet@lwn.net, andreas.werner@men.de, tony@atomide.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, patches@opensource.wolfsonmicro.com Subject: Re: [PATCH V2 19/20] mfd: tps65910: Use devm_mfd_add_devices() for mfd_device registration Message-ID: <20160411093231.GJ7994@x1> References: <1460054594-32325-1-git-send-email-ldewangan@nvidia.com> <1460054594-32325-20-git-send-email-ldewangan@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1460054594-32325-20-git-send-email-ldewangan@nvidia.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Applied, thanks. On Fri, 08 Apr 2016, Laxman Dewangan wrote: > Use devm_mfd_add_devices() for MFD devices registration and remove > the call of mfd_remove_devices() from .remove callback to remove > MFD child-devices. This is done by managed device framework. > > Signed-off-by: Laxman Dewangan > CC: Tony Lindgren > > --- > Changes from V1: > - Convert mfd to MFD. > > drivers/mfd/tps65910.c | 9 ++++----- > 1 file changed, 4 insertions(+), 5 deletions(-) > > diff --git a/drivers/mfd/tps65910.c b/drivers/mfd/tps65910.c > index f7ab115..8086e5d 100644 > --- a/drivers/mfd/tps65910.c > +++ b/drivers/mfd/tps65910.c > @@ -510,10 +510,10 @@ static int tps65910_i2c_probe(struct i2c_client *i2c, > pm_power_off = tps65910_power_off; > } > > - ret = mfd_add_devices(tps65910->dev, -1, > - tps65910s, ARRAY_SIZE(tps65910s), > - NULL, 0, > - regmap_irq_get_domain(tps65910->irq_data)); > + ret = devm_mfd_add_devices(tps65910->dev, -1, > + tps65910s, ARRAY_SIZE(tps65910s), > + NULL, 0, > + regmap_irq_get_domain(tps65910->irq_data)); > if (ret < 0) { > dev_err(&i2c->dev, "mfd_add_devices failed: %d\n", ret); > tps65910_irq_exit(tps65910); > @@ -528,7 +528,6 @@ static int tps65910_i2c_remove(struct i2c_client *i2c) > struct tps65910 *tps65910 = i2c_get_clientdata(i2c); > > tps65910_irq_exit(tps65910); > - mfd_remove_devices(tps65910->dev); > > return 0; > } -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog