Re: [PATCH v5 2/2] auxdisplay: ht16k33: Driver for LED controller

Rob Herring
2016-04-11T14:50:05Z

On Thu, Apr 07, 2016 at 10:54:01AM +0200, Robin van der Gracht wrote:
> Added a driver for the Holtek HT16K33 LED controller with keyscan.
>
> Signed-off-by: Robin van der Gracht <robin@protonic.nl>
> ---
> Changes in v5:
> - Updated compatible string
> - the HT16K33_FB_SIZE define now uses BYTES_PER_ROW as multiplier instead of 2
> - Dropped a trailing '\' in ht16k33.txt
> - Shortened commit message (exceeded 80 chars in v4)
>
> .../devicetree/bindings/display/ht16k33.txt | 42 ++
> drivers/auxdisplay/Kconfig | 9 +
> drivers/auxdisplay/Makefile | 1 +
> drivers/auxdisplay/ht16k33.c | 563 +++++++++++++++++++++
> 4 files changed, 615 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/display/ht16k33.txt
> create mode 100644 drivers/auxdisplay/ht16k33.c
>
> diff --git a/Documentation/devicetree/bindings/display/ht16k33.txt b/Documentation/devicetree/bindings/display/ht16k33.txt
> new file mode 100644
> index 0000000..d9694b7
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/ht16k33.txt
> @@ -0,0 +1,42 @@
> +Holtek ht16k33 RAM mapping 16*8 LED controller driver with keyscan
> +-------------------------------------------------------------------------------
> +
> +Required properties:
> +- compatible: "holtek,ht16k33"
> +- reg: I2C slave address of the chip.
> +- interrupt-parent: A phandle pointing to the interrupt controller
> + serving the interrupt for this chip.
> +- interrupts: Interrupt specification for the key pressed interrupt.
> +- refresh-rate-hz: Display update interval in HZ.
> +- debounce-delay-ms: Debouncing interval time in microseconds.

'-ms' is milliseconds, but you have usec... ^^^^^^^^^^^^

Otherwise,

Acked-by: Rob Herring <robh@kernel.org>