From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755602AbcDKQD0 (ORCPT ); Mon, 11 Apr 2016 12:03:26 -0400 Received: from mail.kernel.org ([198.145.29.136]:60051 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753134AbcDKQDY (ORCPT ); Mon, 11 Apr 2016 12:03:24 -0400 Date: Mon, 11 Apr 2016 11:03:18 -0500 From: Rob Herring To: Lee Jones Cc: Wadim Egorov , linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, lgirdwood@gmail.com, broonie@kernel.org, dianders@chromium.org, zyw@rock-chips.com Subject: Re: [RFC 3/3] mfd: dt-bindings: Add RK818 device tree bindings document Message-ID: <20160411160318.GA6478@rob-hp-laptop> References: <1460108861-32818-1-git-send-email-w.egorov@phytec.de> <1460108861-32818-4-git-send-email-w.egorov@phytec.de> <20160411084434.GJ4592@x1> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160411084434.GJ4592@x1> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Apr 11, 2016 at 09:44:34AM +0100, Lee Jones wrote: > On Fri, 08 Apr 2016, Wadim Egorov wrote: > > > Add device tree bindings documentation for rockchip's RK818 pmic. > > > > Signed-off-by: Wadim Egorov > > --- > > Documentation/devicetree/bindings/mfd/rk808.txt | 37 +++++++++++++++++++++++-- > > 1 file changed, 34 insertions(+), 3 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/mfd/rk808.txt b/Documentation/devicetree/bindings/mfd/rk808.txt > > index 4ca6aab..8cceb07 100644 > > --- a/Documentation/devicetree/bindings/mfd/rk808.txt > > +++ b/Documentation/devicetree/bindings/mfd/rk808.txt > > @@ -1,7 +1,11 @@ > > -RK808 Power Management Integrated Circuit > > +RK8xx Power Management Integrated Circuit > > s/xx/XX/ And others say this bikeshed should be lowercase... I say fine as is for bindings. Uppercase for actual part letters, lowercase for wildcards. > > > +The rk8xx family current members: > > +rk808 > > +rk818 > > > > Required properties: > > -- compatible: "rockchip,rk808" > > +- compatible: "rockchip,rk808", "rockchip,rk818" > > - reg: I2C slave address > > - interrupt-parent: The parent interrupt controller. > > - interrupts: the interrupt outputs of the controller. > > @@ -13,6 +17,8 @@ Optional properties: > > default output clock name > > - rockchip,system-power-controller: Telling whether or not this pmic is controlling > > the system power. > > + > > +Optional rk808 properties: > > When mentioning the chip by name, you should always do so using > uppercase, as it is in the datasheet.