From: "sboyd@codeaurora.org" <sboyd@codeaurora.org>
To: Alexey Brodkin <Alexey.Brodkin@synopsys.com>
Cc: Jose Abreu <Jose.Abreu@synopsys.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"mturquette@baylibre.com" <mturquette@baylibre.com>,
Carlos Palminha <CARLOS.PALMINHA@synopsys.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-snps-arc@lists.infradead.org"
<linux-snps-arc@lists.infradead.org>,
Vineet Gupta <Vineet.Gupta1@synopsys.com>,
"linux-clk@vger.kernel.org" <linux-clk@vger.kernel.org>
Subject: Re: [RESEND PATCH v4] clk/axs10x: Add I2S PLL clock driver
Date: Mon, 11 Apr 2016 15:03:20 -0700 [thread overview]
Message-ID: <20160411220320.GB14441@codeaurora.org> (raw)
In-Reply-To: <1460393270.5119.20.camel@synopsys.com>
On 04/11, Alexey Brodkin wrote:
> On Mon, 2016-04-11 at 11:41 +0100, Jose Abreu wrote:
> > + * warranty of any kind, whether express or implied.
> > + */
> > +
> > +#include <linux/platform_device.h>
> > +#include <linux/module.h>
> > +#include <linux/clk-provider.h>
> > +#include <linux/err.h>
> > +#include <linux/device.h>
>
> "linux/platform_device.h" includes "linux/device.h" so you may make this list of headers
> a little bit shorter.
>
> > +#include <linux/of_address.h>
> > +#include <linux/slab.h>
> > +#include <linux/of.h>
>
> "linux/of_address.h" already includes "linux/of.h".
It's ok to include things twice. In fact, its better to avoid any
implicit includes so that if we ever want to remove includes from
other headers we can do so without disturbing this driver.
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2016-04-11 22:03 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-11 10:41 [RESEND PATCH v4] clk/axs10x: Add I2S PLL clock driver Jose Abreu
2016-04-11 16:47 ` Alexey Brodkin
2016-04-11 22:03 ` sboyd [this message]
2016-04-15 12:08 ` Alexey Brodkin
2016-04-15 23:38 ` sboyd
2016-04-15 23:46 ` Stephen Boyd
2016-04-18 10:30 ` Jose Abreu
2016-04-18 11:49 ` Vineet Gupta
2016-04-19 9:13 ` Jose Abreu
2016-04-20 1:54 ` Stephen Boyd
2016-04-20 9:47 ` Jose Abreu
2016-04-20 16:12 ` Alexey Brodkin
2016-04-21 9:51 ` Jose Abreu
2016-04-21 12:18 ` Alexey Brodkin
2016-04-21 13:10 ` Jose Abreu
2016-04-21 14:15 ` Alexey Brodkin
2016-04-22 5:50 ` Vineet Gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160411220320.GB14441@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=Alexey.Brodkin@synopsys.com \
--cc=CARLOS.PALMINHA@synopsys.com \
--cc=Jose.Abreu@synopsys.com \
--cc=Vineet.Gupta1@synopsys.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-snps-arc@lists.infradead.org \
--cc=mturquette@baylibre.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).