* [PATCH RESEND] sst: fix missing breaks that would cause the wrong operation to execute
@ 2016-04-06 13:44 Alan
2016-04-07 1:30 ` Yang Jie
0 siblings, 1 reply; 3+ messages in thread
From: Alan @ 2016-04-06 13:44 UTC (permalink / raw)
To: yang.jie, linux-kernel
From: Alan <gnomes@lxorguk.ukuu.org.uk>
Now we correctly error an attempt to execute an unsupported operation. The
current code does something else random.
Signed-off-by: Alan Cox <alan@linux.intel.com>
---
sound/soc/intel/atom/sst-mfld-platform-compress.c | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/sound/soc/intel/atom/sst-mfld-platform-compress.c b/sound/soc/intel/atom/sst-mfld-platform-compress.c
index 3951689..1bead81 100644
--- a/sound/soc/intel/atom/sst-mfld-platform-compress.c
+++ b/sound/soc/intel/atom/sst-mfld-platform-compress.c
@@ -182,24 +182,29 @@ static int sst_platform_compr_trigger(struct snd_compr_stream *cstream, int cmd)
case SNDRV_PCM_TRIGGER_START:
if (stream->compr_ops->stream_start)
return stream->compr_ops->stream_start(sst->dev, stream->id);
+ break;
case SNDRV_PCM_TRIGGER_STOP:
if (stream->compr_ops->stream_drop)
return stream->compr_ops->stream_drop(sst->dev, stream->id);
+ break;
case SND_COMPR_TRIGGER_DRAIN:
if (stream->compr_ops->stream_drain)
return stream->compr_ops->stream_drain(sst->dev, stream->id);
+ break;
case SND_COMPR_TRIGGER_PARTIAL_DRAIN:
if (stream->compr_ops->stream_partial_drain)
return stream->compr_ops->stream_partial_drain(sst->dev, stream->id);
+ break;
case SNDRV_PCM_TRIGGER_PAUSE_PUSH:
if (stream->compr_ops->stream_pause)
return stream->compr_ops->stream_pause(sst->dev, stream->id);
+ break;
case SNDRV_PCM_TRIGGER_PAUSE_RELEASE:
if (stream->compr_ops->stream_pause_release)
return stream->compr_ops->stream_pause_release(sst->dev, stream->id);
- default:
- return -EINVAL;
+ break;
}
+ return -EINVAL;
}
static int sst_platform_compr_pointer(struct snd_compr_stream *cstream,
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH RESEND] sst: fix missing breaks that would cause the wrong operation to execute
2016-04-06 13:44 [PATCH RESEND] sst: fix missing breaks that would cause the wrong operation to execute Alan
@ 2016-04-07 1:30 ` Yang Jie
2016-04-12 5:05 ` Vinod Koul
0 siblings, 1 reply; 3+ messages in thread
From: Yang Jie @ 2016-04-07 1:30 UTC (permalink / raw)
To: Alan, linux-kernel, Vinod Koul
On 2016年04月06日 21:44, Alan wrote:
> From: Alan <gnomes@lxorguk.ukuu.org.uk>
>
> Now we correctly error an attempt to execute an unsupported operation. The
> current code does something else random.
>
> Signed-off-by: Alan Cox <alan@linux.intel.com>
I think this is nice fix. + Vinod who is the owner of the atom sound driver.
Thanks,
~Keyon
> ---
> sound/soc/intel/atom/sst-mfld-platform-compress.c | 9 +++++++--
> 1 file changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/sound/soc/intel/atom/sst-mfld-platform-compress.c b/sound/soc/intel/atom/sst-mfld-platform-compress.c
> index 3951689..1bead81 100644
> --- a/sound/soc/intel/atom/sst-mfld-platform-compress.c
> +++ b/sound/soc/intel/atom/sst-mfld-platform-compress.c
> @@ -182,24 +182,29 @@ static int sst_platform_compr_trigger(struct snd_compr_stream *cstream, int cmd)
> case SNDRV_PCM_TRIGGER_START:
> if (stream->compr_ops->stream_start)
> return stream->compr_ops->stream_start(sst->dev, stream->id);
> + break;
> case SNDRV_PCM_TRIGGER_STOP:
> if (stream->compr_ops->stream_drop)
> return stream->compr_ops->stream_drop(sst->dev, stream->id);
> + break;
> case SND_COMPR_TRIGGER_DRAIN:
> if (stream->compr_ops->stream_drain)
> return stream->compr_ops->stream_drain(sst->dev, stream->id);
> + break;
> case SND_COMPR_TRIGGER_PARTIAL_DRAIN:
> if (stream->compr_ops->stream_partial_drain)
> return stream->compr_ops->stream_partial_drain(sst->dev, stream->id);
> + break;
> case SNDRV_PCM_TRIGGER_PAUSE_PUSH:
> if (stream->compr_ops->stream_pause)
> return stream->compr_ops->stream_pause(sst->dev, stream->id);
> + break;
> case SNDRV_PCM_TRIGGER_PAUSE_RELEASE:
> if (stream->compr_ops->stream_pause_release)
> return stream->compr_ops->stream_pause_release(sst->dev, stream->id);
> - default:
> - return -EINVAL;
> + break;
> }
> + return -EINVAL;
> }
>
> static int sst_platform_compr_pointer(struct snd_compr_stream *cstream,
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH RESEND] sst: fix missing breaks that would cause the wrong operation to execute
2016-04-07 1:30 ` Yang Jie
@ 2016-04-12 5:05 ` Vinod Koul
0 siblings, 0 replies; 3+ messages in thread
From: Vinod Koul @ 2016-04-12 5:05 UTC (permalink / raw)
To: Yang Jie; +Cc: Alan, linux-kernel
On Thu, Apr 07, 2016 at 09:30:44AM +0800, Yang Jie wrote:
>
>
> On 2016年04月06日 21:44, Alan wrote:
> >From: Alan <gnomes@lxorguk.ukuu.org.uk>
> >
> >Now we correctly error an attempt to execute an unsupported operation. The
> >current code does something else random.
Hi Alan,
Can you either send me this patch or send this to ALSA mailing list.
You might want to add the subsystem name which here should be:
ASoC: Intel: atom: fix missing breaks that would cause the wrong operation
to execute
And you can add my Ack :)
Acked-by: Vinod Koul <vinod.koul@intel.com>
Thanks
--
~Vinod
> >
> >Signed-off-by: Alan Cox <alan@linux.intel.com>
>
> I think this is nice fix. + Vinod who is the owner of the atom sound driver.
>
> Thanks,
> ~Keyon
>
> >---
> > sound/soc/intel/atom/sst-mfld-platform-compress.c | 9 +++++++--
> > 1 file changed, 7 insertions(+), 2 deletions(-)
> >
> >diff --git a/sound/soc/intel/atom/sst-mfld-platform-compress.c b/sound/soc/intel/atom/sst-mfld-platform-compress.c
> >index 3951689..1bead81 100644
> >--- a/sound/soc/intel/atom/sst-mfld-platform-compress.c
> >+++ b/sound/soc/intel/atom/sst-mfld-platform-compress.c
> >@@ -182,24 +182,29 @@ static int sst_platform_compr_trigger(struct snd_compr_stream *cstream, int cmd)
> > case SNDRV_PCM_TRIGGER_START:
> > if (stream->compr_ops->stream_start)
> > return stream->compr_ops->stream_start(sst->dev, stream->id);
> >+ break;
> > case SNDRV_PCM_TRIGGER_STOP:
> > if (stream->compr_ops->stream_drop)
> > return stream->compr_ops->stream_drop(sst->dev, stream->id);
> >+ break;
> > case SND_COMPR_TRIGGER_DRAIN:
> > if (stream->compr_ops->stream_drain)
> > return stream->compr_ops->stream_drain(sst->dev, stream->id);
> >+ break;
> > case SND_COMPR_TRIGGER_PARTIAL_DRAIN:
> > if (stream->compr_ops->stream_partial_drain)
> > return stream->compr_ops->stream_partial_drain(sst->dev, stream->id);
> >+ break;
> > case SNDRV_PCM_TRIGGER_PAUSE_PUSH:
> > if (stream->compr_ops->stream_pause)
> > return stream->compr_ops->stream_pause(sst->dev, stream->id);
> >+ break;
> > case SNDRV_PCM_TRIGGER_PAUSE_RELEASE:
> > if (stream->compr_ops->stream_pause_release)
> > return stream->compr_ops->stream_pause_release(sst->dev, stream->id);
> >- default:
> >- return -EINVAL;
> >+ break;
> > }
> >+ return -EINVAL;
> > }
> >
> > static int sst_platform_compr_pointer(struct snd_compr_stream *cstream,
> >
> >
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-04-12 5:01 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-04-06 13:44 [PATCH RESEND] sst: fix missing breaks that would cause the wrong operation to execute Alan
2016-04-07 1:30 ` Yang Jie
2016-04-12 5:05 ` Vinod Koul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).