From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] rcu: Remove some superfluous lines
Date: Tue, 12 Apr 2016 07:44:00 -0700 [thread overview]
Message-ID: <20160412144400.GB3568@linux.vnet.ibm.com> (raw)
In-Reply-To: <20160310135500.GQ6356@twins.programming.kicks-ass.net>
On Thu, Mar 10, 2016 at 02:55:00PM +0100, Peter Zijlstra wrote:
> On Thu, Mar 10, 2016 at 05:41:46AM -0800, Paul E. McKenney wrote:
> > On Thu, Mar 10, 2016 at 09:49:04AM +0100, Peter Zijlstra wrote:
> > >
> > > I think you'll find this condition is superfluous, as the whole function
> > > is under #ifdef of that same.
> > >
> > > Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
> >
> > Right you are! It got moved under that #ifdef in the process of merging
> > the RCU, hotplug, and swait changes, and I failed to notice. Good catch!
> >
> > I will apply this to my tree once -rc1 comes out, as it will apply to
> > -rcu at that point.
> >
> > Or maybe we should remove the #ifdef and add IS_ENABLED() to the other
> > functions under that #ifdef. Thoughts?
>
> I'd go with the #ifdef, its the conventional pattern.
Longer term, I am moving from #ifdef to IS_ENABLED(), as it makes for
easier detection of compiler errors in oddball combinations of Kconfig
options. But no point in carrying redundant code in the meantime,
so queued for 4.8.
Thanx, Paul
prev parent reply other threads:[~2016-04-12 14:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-10 8:49 [PATCH] rcu: Remove some superfluous lines Peter Zijlstra
2016-03-10 13:41 ` Paul E. McKenney
2016-03-10 13:55 ` Peter Zijlstra
2016-04-12 14:44 ` Paul E. McKenney [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160412144400.GB3568@linux.vnet.ibm.com \
--to=paulmck@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox