[PATCH] mtd: nand: gpmi: get correct free oob space

[PATCH] mtd: nand: gpmi: get correct free oob space

[Han Xu]

change the way to calculate pagesize to get correct free oob space for
legacy_set_geometry function.

Signed-off-by: Han Xu <han.xu@nxp.com>
---
 drivers/mtd/nand/gpmi-nand/gpmi-nand.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/mtd/nand/gpmi-nand/gpmi-nand.c b/drivers/mtd/nand/gpmi-nand/gpmi-nand.c
index 316b5ac..bda77a9 100644
--- a/drivers/mtd/nand/gpmi-nand/gpmi-nand.c
+++ b/drivers/mtd/nand/gpmi-nand/gpmi-nand.c
@@ -319,7 +319,8 @@ static int legacy_set_geometry(struct gpmi_nand_data *this)
 		return -EINVAL;
 	}
 
-	geo->page_size = mtd->writesize + mtd->oobsize;
+	geo->page_size = mtd->writesize + geo->metadata_size +
+		(geo->gf_len * geo->ecc_strength * geo->ecc_chunk_count) / 8;
 	geo->payload_size = mtd->writesize;
 
 	/*
-- 
1.9.1

Re: [PATCH] mtd: nand: gpmi: get correct free oob space

[Boris Brezillon]

Hi Han,

On Tue, 12 Apr 2016 17:06:33 -0500
Han Xu <han.xu@nxp.com> wrote:

> change the way to calculate pagesize to get correct free oob space for
> legacy_set_geometry function.

Are you sure it's safe to expose free OOB bytes in this case? Do you
know why it wasn't done before?

Best Regards,

Boris

> 
> Signed-off-by: Han Xu <han.xu@nxp.com>
> ---
>  drivers/mtd/nand/gpmi-nand/gpmi-nand.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/mtd/nand/gpmi-nand/gpmi-nand.c b/drivers/mtd/nand/gpmi-nand/gpmi-nand.c
> index 316b5ac..bda77a9 100644
> --- a/drivers/mtd/nand/gpmi-nand/gpmi-nand.c
> +++ b/drivers/mtd/nand/gpmi-nand/gpmi-nand.c
> @@ -319,7 +319,8 @@ static int legacy_set_geometry(struct gpmi_nand_data *this)
>  		return -EINVAL;
>  	}
>  
> -	geo->page_size = mtd->writesize + mtd->oobsize;
> +	geo->page_size = mtd->writesize + geo->metadata_size +
> +		(geo->gf_len * geo->ecc_strength * geo->ecc_chunk_count) / 8;
>  	geo->payload_size = mtd->writesize;
>  
>  	/*



-- 
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

Re: [PATCH] mtd: nand: gpmi: get correct free oob space

[Boris Brezillon]

Hi Han,

On Wed, 13 Apr 2016 00:43:51 +0200
Boris Brezillon <boris.brezillon@free-electrons.com> wrote:

> Hi Han,
> 
> On Tue, 12 Apr 2016 17:06:33 -0500
> Han Xu <han.xu@nxp.com> wrote:
> 
> > change the way to calculate pagesize to get correct free oob space for
> > legacy_set_geometry function.  
> 
> Are you sure it's safe to expose free OOB bytes in this case? Do you
> know why it wasn't done before?

You did not answer this question. Do you want me to drop this patch. If
that's not the case, can you confirm it does not break platforms that
didn't have those free OOB bytes exposed before this change.

Thanks,

Boris


-- 
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

Re: [PATCH] mtd: nand: gpmi: get correct free oob space

[Han Xu]

________________________________________
From: Boris Brezillon <boris.brezillon@free-electrons.com>
Sent: Friday, April 29, 2016 2:31 AM
To: Han Xu
Cc: richard@nod.at; dwmw2@infradead.org; computersforpeace@gmail.com; linux-mtd@lists.infradead.org; linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mtd: nand: gpmi: get correct free oob space

Hi Han,

On Wed, 13 Apr 2016 00:43:51 +0200
Boris Brezillon <boris.brezillon@free-electrons.com> wrote:

> Hi Han,
>
> On Tue, 12 Apr 2016 17:06:33 -0500
> Han Xu <han.xu@nxp.com> wrote:
>
> > change the way to calculate pagesize to get correct free oob space for
> > legacy_set_geometry function.
>
> Are you sure it's safe to expose free OOB bytes in this case? Do you
> know why it wasn't done before?

You did not answer this question. Do you want me to drop this patch. If
that's not the case, can you confirm it does not break platforms that
didn't have those free OOB bytes exposed before this change.

I think it's safe to expose the free OOB and also tested on my side, no
issue found.

Thanks,

Boris


--
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

Re: [PATCH] mtd: nand: gpmi: get correct free oob space

[Boris Brezillon]

On Tue, 12 Apr 2016 17:06:33 -0500
Han Xu <han.xu@nxp.com> wrote:

> change the way to calculate pagesize to get correct free oob space for
> legacy_set_geometry function.
> 

Applied (sorry for the delay, it seems this patch felt through the
cracks).

Thanks,

Boris

> Signed-off-by: Han Xu <han.xu@nxp.com>
> ---
>  drivers/mtd/nand/gpmi-nand/gpmi-nand.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/mtd/nand/gpmi-nand/gpmi-nand.c b/drivers/mtd/nand/gpmi-nand/gpmi-nand.c
> index 316b5ac..bda77a9 100644
> --- a/drivers/mtd/nand/gpmi-nand/gpmi-nand.c
> +++ b/drivers/mtd/nand/gpmi-nand/gpmi-nand.c
> @@ -319,7 +319,8 @@ static int legacy_set_geometry(struct gpmi_nand_data *this)
>  		return -EINVAL;
>  	}
>  
> -	geo->page_size = mtd->writesize + mtd->oobsize;
> +	geo->page_size = mtd->writesize + geo->metadata_size +
> +		(geo->gf_len * geo->ecc_strength * geo->ecc_chunk_count) / 8;
>  	geo->payload_size = mtd->writesize;
>  
>  	/*