From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966163AbcDMJmH (ORCPT ); Wed, 13 Apr 2016 05:42:07 -0400 Received: from mail-wm0-f68.google.com ([74.125.82.68]:36562 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965973AbcDMJmD (ORCPT ); Wed, 13 Apr 2016 05:42:03 -0400 Date: Wed, 13 Apr 2016 11:41:59 +0200 From: Ingo Molnar To: Daniel Lezcano Cc: peterz@infradead.org, Ingo Molnar , "open list:SCHEDULER" Subject: Re: [PATCH] sched/clock: Make local_clock/cpu_clock inline Message-ID: <20160413094158.GA6430@gmail.com> References: <1459541050-13654-1-git-send-email-daniel.lezcano@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1459541050-13654-1-git-send-email-daniel.lezcano@linaro.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Daniel Lezcano wrote: > The local_clock/cpu_clock functions were changed to prevent a double > identical test with sched_clock_cpu() when HAVE_UNSTABLE_SCHED_CLOCK > is set. That resulted in one line functions. > > As these functions are in all the cases one line functions and in the > hot path, it is useful to specify them as static inline in order to > give a strong hint to the compiler. > > After verification, it appears the compiler does not inline them > without this hint. Change those functions to static inline. > > Signed-off-by: Daniel Lezcano > --- > include/linux/sched.h | 32 ++++++++++++++++++++++++++++++-- > kernel/sched/clock.c | 41 ----------------------------------------- > 2 files changed, 30 insertions(+), 43 deletions(-) Hm, this does not seem to apply to v4.6-rc3 cleanly. Thanks, Ingo