public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Serge E. Hallyn" <serge@hallyn.com>
To: Tejun Heo <tj@kernel.org>
Cc: "Serge E. Hallyn" <serge@hallyn.com>,
	linux-api@vger.kernel.org, adityakali@google.com,
	Linux Containers <containers@lists.osdl.org>,
	"Eric W. Biederman" <ebiederm@xmission.com>,
	cgroups@vger.kernel.org, lkml <linux-kernel@vger.kernel.org>
Subject: Re: [RFC PATCH] cgroup namespaces: add a 'nsroot=' mountinfo field
Date: Wed, 13 Apr 2016 14:01:52 -0500	[thread overview]
Message-ID: <20160413190152.GA29753@mail.hallyn.com> (raw)
In-Reply-To: <20160413185033.GH3676@htj.duckdns.org>

Quoting Tejun Heo (tj@kernel.org):
> Hello, Serge.
> 
> On Wed, Apr 13, 2016 at 01:46:39PM -0500, Serge E. Hallyn wrote:
> > It's not a leak of any information we're trying to hide.  I realize
> > something like 8 years have passed, but I still basically go by the
> > ksummit guidance that containers are ok but the kernel's first priority
> > is to facilitate containers but not trick containers into thinking
> > they're not containerized.  So long as the container is properly set
> > up, I don't think there's anything the workload could do with the
> > nsroot= info other than *know* that it is in a ns cgroup.
> > 
> > If we did change that guidance, there's a slew of proc info that we
> > could better virtualize :)
> 
> I see.  I'm just wondering because the information here seems a bit
> gratuituous.  Isn't the only thing necessary telling whether the root
> is bind mounted or namescoped?  Wouldn't simple "nsroot" work for that
> purpose?

I don't think so - we could be in a cgroup namespace but still have
access only to bind-mounted cgroups.  So we need to compare the
superblock dentry root field to the nsroot= value.

  reply	other threads:[~2016-04-13 19:01 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-21 23:41 [RFC PATCH] cgroup namespaces: add a 'nsroot=' mountinfo field Serge E. Hallyn
2016-03-29  1:12 ` Serge E. Hallyn
2016-03-30 18:58   ` Tejun Heo
2016-03-29 13:58 ` Tycho Andersen
2016-03-29 20:00   ` Serge E. Hallyn
2016-03-30 17:21     ` [PATCH] cgroup mount: ignore nsroot= Serge E. Hallyn
2016-03-30 18:09       ` Tycho Andersen
2016-04-13 17:57 ` [RFC PATCH] cgroup namespaces: add a 'nsroot=' mountinfo field Tejun Heo
2016-04-13 18:46   ` Serge E. Hallyn
2016-04-13 18:50     ` Tejun Heo
2016-04-13 19:01       ` Serge E. Hallyn [this message]
2016-04-13 19:12         ` Tejun Heo
2016-04-13 23:31         ` Aditya Kali
2016-04-13 23:52           ` Serge E. Hallyn
2016-04-14  4:04   ` [PATCH] " Serge E. Hallyn
2016-04-14 14:42     ` Eric W. Biederman
2016-04-14 15:27       ` Serge E. Hallyn
2016-04-14 16:12         ` Eric W. Biederman
2016-04-14 16:38           ` Serge E. Hallyn
2016-04-14 16:43             ` Eric W. Biederman
2016-04-15 15:50         ` Aditya Kali
2016-04-15 16:02           ` Serge E. Hallyn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160413190152.GA29753@mail.hallyn.com \
    --to=serge@hallyn.com \
    --cc=adityakali@google.com \
    --cc=cgroups@vger.kernel.org \
    --cc=containers@lists.osdl.org \
    --cc=ebiederm@xmission.com \
    --cc=linux-api@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox