From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752626AbcDNBx1 (ORCPT ); Wed, 13 Apr 2016 21:53:27 -0400 Received: from mout.kundenserver.de ([217.72.192.75]:57574 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752564AbcDNBxZ (ORCPT ); Wed, 13 Apr 2016 21:53:25 -0400 From: Arnd Bergmann To: Dan Carpenter Subject: Re: [patch] ARM: qcom: silence an uninitialized variable warning Date: Thu, 14 Apr 2016 03:53:03 +0200 User-Agent: KMail/1.12.2 (Linux/3.19.0-58-generic; KDE/4.3.2; x86_64; ; ) Cc: Tim Bird , "Greg Kroah-Hartman" , linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org References: <20160413064511.GG8092@mwanda> In-Reply-To: <20160413064511.GG8092@mwanda> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201604140353.03595.arnd@arndb.de> X-Provags-ID: V03:K0:8nZLiGnyXKaU2pUyBl3AA8SRSw/MCKc2eK0i8x7Zd5D7pl4yc4F xZWlnbwKEKHIJ6vm8B8b8FW8mZsVVIgfAGkAcmZuRL4pp4rNiBiMXCoQN+clnPQ/8PmLYg4 Jv5lDkwMUEa/xvRHTzzBg9brqsn2DN2Bw3N/dC6tCJVLfpxS6mw9YryShhYmtoQ0nv30/yZ VEes+tOqcfkMFsjfYDV0w== X-UI-Out-Filterresults: notjunk:1;V01:K0:ROPintnRnzI=:wb6kfYdJy2wjDeEAiJnKrQ UtBi0C8krJifvtsry6nh5m+r2Ibwf9EpurAvDfU8kZhYXJV7dXa08T3i5qobxDxiNVqD5tJ28 tmL9IHLa+vB6gX4hCOAZEvZsibn8eZmK5s/7hQnx4JUoBk5swbXnP8pDAtMx3EmdNumdoExBE xH7d3mzHzucQLzh7w33mCAHdZk38xA8H2b58JR2uFPM0xHQWdqXZDACz9SW9hYU6EU16ldTrK k/gmxbgCUy35wnSUS0y3xI924ZJLQEFTCaEeUCO4QMJvNgXo6bJY+h8hJrWbrqr0cI1tqQdRV E2wgWD3DDvA9VDj87OLWSqtIWuvqy4cQr4SJxi1wcKejiIRmvrU4INgNEXhESEHQggsWVGSBe 7uF1keOE2soWjnhxB2nmAhrdTxRA+HHbAoML5utR3O/Fb3zmYbKEgPV2H7+2TaZ1SBh79O+/M e0wUp8OVbEvCbmytcdswpm7VhwTRLBaP/HwaaGqTHwwNm6X8Fu6o5U4YFhCJQqvDkuqM88raY rKAuaU2mBJjFWfnvhAPUMH6LFAaKdh0yr/CVOxoXDO/YR1UUh8f2kjEnRjNdHU8X53m7bzcYx +lunuqw5AL8a3A+d6TeMcQc3jCETLnUCokYyS6TA+WvQEnHm4Z7C7XmTYcq4nRnLOueNjoo6j Dge3T1siTcmLOjXpdYyj8HrfjxZqxoUG962hkVNzBNfqq7qFI/oWTGU5bGHz9XWzEZgSrd9ms I8N8+F/D9CG2/JT1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wednesday 13 April 2016, Dan Carpenter wrote: > It's harmless but, if "enable" isn't set, then we pass uninitialized > values to qcom_coincell_chgr_config(). The values aren't used, but > let's silence the warning anyway. > > Signed-off-by: Dan Carpenter I haven't seen this warning in my tests, which means it probably doesn't show up in the usual configurations. Are you sure this doesn't just happen with CONFIG_PROFILE_ALL_BRANCHES, CONFIG_CC_OPTIMIZE_FOR_SIZE or CONFIG_GCOV_PROFILE_ALL, or with versions of gcc before 4.9? Arnd > diff --git a/drivers/misc/qcom-coincell.c b/drivers/misc/qcom-coincell.c > index 7b4a2da..829a61d 100644 > --- a/drivers/misc/qcom-coincell.c > +++ b/drivers/misc/qcom-coincell.c > @@ -94,7 +94,8 @@ static int qcom_coincell_probe(struct platform_device *pdev) > { > struct device_node *node = pdev->dev.of_node; > struct qcom_coincell chgr; > - u32 rset, vset; > + u32 rset = 0; > + u32 vset = 0; > bool enable; > int rc; > >