From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752698AbcDNHTK (ORCPT ); Thu, 14 Apr 2016 03:19:10 -0400 Received: from down.free-electrons.com ([37.187.137.238]:36906 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750974AbcDNHTJ (ORCPT ); Thu, 14 Apr 2016 03:19:09 -0400 Date: Thu, 14 Apr 2016 09:19:02 +0200 From: Alexandre Belloni To: Tomas Krcka Cc: rtc-linux@googlegroups.com, Alessandro Zummo , linux-kernel@vger.kernel.org Subject: Re: [PATCH] rtc: support for rv4162c7 Message-ID: <20160414071902.GK7765@piout.net> References: <570EAE8B.7010706@nkgroup.cz> <20160413224916.GH7765@piout.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 14/04/2016 at 08:29:47 +0200, Tomas Krcka wrote : > Hi, > that's correct, but idetification of this chip is rv4162c7 so > i2c_match_id() returns NULL. > If it's there any workaround, how the chip can be detected > automatically then OK, but without this patch it doesn't work for me. > Just use rv4162 as your compatible string. That is what the mainline dtsi is doing for the phycore som: $ grep -C 2 rv4162 arch/arm/boot/dts/am335x-phycore-som.dtsi i2c_rtc: rtc@68 { compatible = "rv4162"; reg = <0x68>; status = "disabled"; > 2016-04-14 0:49 GMT+02:00 Alexandre Belloni > : > > Hi, > > > > On 13/04/2016 at 22:39:39 +0200, Tomas Krcka wrote : > >> This patch is for support of rv4162c7 RTC chip. > >> The device has same parameters as rv4162, but with different identification. > >> Tested with PhyTec module AM335x. > >> > > > > Well, technically, it is an rv4162. rv4162-c7 is the only available one. > > So this patch is not necessary. > > > >> Signed-off-by: Tomas Krcka > >> > >> --- > >> drivers/rtc/rtc-m41t80.c | 1 + > >> 1 file changed, 1 insertion(+) > >> > >> diff --git a/drivers/rtc/rtc-m41t80.c b/drivers/rtc/rtc-m41t80.c > >> index d107a8e..1aa57d8 100644 > >> --- a/drivers/rtc/rtc-m41t80.c > >> +++ b/drivers/rtc/rtc-m41t80.c > >> @@ -81,6 +81,7 @@ static const struct i2c_device_id m41t80_id[] = { > >> { "m41st85", M41T80_FEATURE_HT | M41T80_FEATURE_BL | M41T80_FEATURE_SQ }, > >> { "m41st87", M41T80_FEATURE_HT | M41T80_FEATURE_BL | M41T80_FEATURE_SQ }, > >> { "rv4162", M41T80_FEATURE_SQ | M41T80_FEATURE_WD | M41T80_FEATURE_SQ_ALT }, > >> + { "rv4162c7", M41T80_FEATURE_SQ | M41T80_FEATURE_WD | M41T80_FEATURE_SQ_ALT }, > >> { } > >> }; > >> MODULE_DEVICE_TABLE(i2c, m41t80_id); > >> -- 1.9.1 > >> > > > > -- > > Alexandre Belloni, Free Electrons > > Embedded Linux, Kernel and Android engineering > > http://free-electrons.com -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com