From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964907AbcDNRNl (ORCPT ); Thu, 14 Apr 2016 13:13:41 -0400 Received: from foss.arm.com ([217.140.101.70]:44684 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932420AbcDNRNk (ORCPT ); Thu, 14 Apr 2016 13:13:40 -0400 Date: Thu, 14 Apr 2016 18:13:39 +0100 From: Will Deacon To: Anna-Maria Gleixner Cc: linux-kernel@vger.kernel.org, rt@linutronix.de, Catalin Marinas , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2] arm64/debug: Remove superfluous SMP function call Message-ID: <20160414171338.GL4584@arm.com> References: <1459932148-44003-1-git-send-email-anna-maria@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1459932148-44003-1-git-send-email-anna-maria@linutronix.de> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 06, 2016 at 10:42:28AM +0200, Anna-Maria Gleixner wrote: > Since commit 1cf4f629d9d2 ("cpu/hotplug: Move online calls to > hotplugged cpu") it is ensured that callbacks of CPU_ONLINE and > CPU_DOWN_PREPARE are processed on the hotplugged CPU. Due to this SMP > function calls are no longer required. > > Replace smp_call_function_single() with a direct call to > clear_os_lock(). The function writes the OSLAR register to clear OS > locking. This does not require to be called with interrupts disabled, > therefore the smp_call_function_single() calling convention is not > preserved. > > Cc: Catalin Marinas > Cc: Will Deacon > Cc: linux-arm-kernel@lists.infradead.org > Signed-off-by: Anna-Maria Gleixner > --- > arch/arm64/kernel/debug-monitors.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) Applied this and the hw_breakpoint one too, thanks. Will