From: Al Viro <viro@ZenIV.linux.org.uk>
To: Andrey Ulanov <andreyu@google.com>
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] namespace: update event counter when umounting a deleted dentry
Date: Fri, 15 Apr 2016 01:50:38 +0100 [thread overview]
Message-ID: <20160415005038.GU25498@ZenIV.linux.org.uk> (raw)
In-Reply-To: <1460677712-26909-1-git-send-email-andreyu@google.com>
On Thu, Apr 14, 2016 at 04:48:32PM -0700, Andrey Ulanov wrote:
> +++ b/fs/namespace.c
> @@ -1562,6 +1562,7 @@ void __detach_mounts(struct dentry *dentry)
> goto out_unlock;
>
> lock_mount_hash();
> + event++;
That part makes sense.
> -/*
> +/*
> * Is the caller allowed to modify his namespace?
> */
> static inline bool may_mount(void)
> @@ -1765,6 +1766,7 @@ void drop_collected_mounts(struct vfsmount *mnt)
> {
> namespace_lock();
> lock_mount_hash();
> + event++;
... but what the hell is this one for?
next prev parent reply other threads:[~2016-04-15 0:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-14 23:48 [PATCH] namespace: update event counter when umounting a deleted dentry Andrey Ulanov
2016-04-15 0:50 ` Al Viro [this message]
2016-04-15 21:24 ` Andrey Ulanov
2016-04-15 21:29 ` Andrey Ulanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160415005038.GU25498@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=andreyu@google.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox