From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753490AbcDOG4L (ORCPT ); Fri, 15 Apr 2016 02:56:11 -0400 Received: from mail-wm0-f66.google.com ([74.125.82.66]:35914 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752728AbcDOG4F (ORCPT ); Fri, 15 Apr 2016 02:56:05 -0400 Date: Fri, 15 Apr 2016 08:55:59 +0200 From: Ingo Molnar To: Kees Cook Cc: Baoquan He , Ingo Molnar , LKML , Yinghai Lu , "H. Peter Anvin" , Borislav Petkov , Vivek Goyal , Andy Lutomirski , lasse.collin@tukaani.org, Andrew Morton , Dave Young , "kernel-hardening@lists.openwall.com" Subject: Re: [PATCH v4 00/20] x86, boot: kaslr cleanup and 64bit kaslr support Message-ID: <20160415065559.GA30715@gmail.com> References: <1458631937-14593-1-git-send-email-bhe@redhat.com> <20160405015613.GA4654@x1.redhat.com> <20160413101950.GC9482@gmail.com> <20160414150641.GA2599@x1.redhat.com> <20160415040830.GB2631@x1.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Kees Cook wrote: > On Thu, Apr 14, 2016 at 9:08 PM, Baoquan He wrote: > >> I will split these chunks up into the correct patches and resend the series. > >> If you get a chance, can you double-check this? > > > > Yes, these changes sounds great. I checked the series you posted, and have to > > say you make them look much better. The change logs are perfect and great code > > refactoring. Just one little bit thing, here: > > > > [kees: rewrote changelog, refactored goto into while, limit 32-bit to 1G] in > > patch [PATCH v5 19/21] x86, KASLR: Add physical address randomization >4G > > > > In i386 KERNEL_IMAGE_SIZE is kept to be 0x20000000, namely 512M, w/o kaslr > > enabled. So here I guess it's a typo, should be "limit 32-bit to 1G". And what > > I said is wrong about upper limit yesterday, in fact i386 can put kernel in > > [16M, 896M), not 768M. But KERNEL_IMAGE_SIZE is good enough for i386 for now. > > Ah yeah, thanks. If we do a v6, I'll update the typo. I was going to say "limit > 32-bit to KERNEL_IMAGE_SIZE" but it was going to line-wrap. > :P No need to resend, I've fixed the changelog. Thanks, Ingo