Re: [RESEND 07/11] pwm: sti: Initialise PWM Capture channel data

Thierry Reding
2016-04-15T14:23:23Z

[-- Attachment #1: Type: text/plain, Size: 950 bytes --]

On Fri, Apr 15, 2016 at 02:11:46PM +0100, Lee Jones wrote:
> On Tue, 12 Apr 2016, Thierry Reding wrote:
> > On Wed, Mar 02, 2016 at 03:32:05PM +0000, Lee Jones wrote:
> > [...]
> > > +struct sti_cpt_data {
> > > + u32 snapshot[3];
> > > + int index;
> > > + int gpio;
>
> [...]
>
> > > +
> > > + init_waitqueue_head(&data->wait);
> > > + mutex_init(&data->lock);
> > > + data->gpio = of_get_named_gpio(np, "capture-gpios", chan);
> > > + pc->cpt_data[chan] = data;
> >
> > Converting to per-PWM data should be as simple as turning this last line
> > into:
> >
> > pwm_set_chip_data(pc->chip.pwms[chan], data);
> >
> > Also I don't see any cleanup for this data in the driver. The memory for
> > the per-PWM data should be freed by devm_*() infrastructure, but how
> > will the GPIO be released?
>
> There is no reason to release a GPIO.

Why? If you request it why would you not need to release it?

Thierry

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]