From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751738AbcDOOba (ORCPT ); Fri, 15 Apr 2016 10:31:30 -0400 Received: from mail-wm0-f50.google.com ([74.125.82.50]:33022 "EHLO mail-wm0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751351AbcDOOb2 (ORCPT ); Fri, 15 Apr 2016 10:31:28 -0400 Date: Fri, 15 Apr 2016 15:31:22 +0100 From: Lee Jones To: Thierry Reding Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kernel@stlinux.com, maxime.coquelin@st.com, linux-pwm@vger.kernel.org, ajitpal.singh@st.com Subject: Re: [RESEND 07/11] pwm: sti: Initialise PWM Capture channel data Message-ID: <20160415143122.GF3589@x1> References: <1456932729-9667-1-git-send-email-lee.jones@linaro.org> <1456932729-9667-8-git-send-email-lee.jones@linaro.org> <20160412102926.GC18882@ulmo.ba.sec> <20160415123941.GD3589@x1> <20160415142243.GE3472@ulmo.ba.sec> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20160415142243.GE3472@ulmo.ba.sec> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 15 Apr 2016, Thierry Reding wrote: > On Fri, Apr 15, 2016 at 01:39:41PM +0100, Lee Jones wrote: > > On Tue, 12 Apr 2016, Thierry Reding wrote: > > > > > On Wed, Mar 02, 2016 at 03:32:05PM +0000, Lee Jones wrote: > > > [...] > > > > +struct sti_cpt_data { > > > > + u32 snapshot[3]; > > > > + int index; > > > > + int gpio; > > > > > > On a side-note, this should probably use struct gpio_desc * instead of > > > an integer along with the gpiod_*() APIs for the GPIO handling. > > > > Why would you need to do that? > > > > of_get_named_gpio() does all that for you. > > Use the of_get_named_gpio*d*() function instead. My understanding is > that referring to GPIOs by integer is deprecated and should not be used > in new code. I've since conducted some research and have now converted over to gpiod. Thanks for the pointer. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog