Re: [PATCH v3 13/19] drm: sun4i: Add DT bindings documentation

Maxime Ripard
2016-04-10T15:25:57Z

[-- Attachment #1: Type: text/plain, Size: 8205 bytes --]

Hi Rob,

On Tue, Mar 29, 2016 at 01:50:35PM -0500, Rob Herring wrote:
> On Tue, Mar 29, 2016 at 12:33:14PM +0200, Maxime Ripard wrote:
> > Hi Rob,
> >
> > On Fri, Mar 25, 2016 at 09:11:18AM -0500, Rob Herring wrote:
> > > On Wed, Mar 23, 2016 at 05:38:36PM +0100, Maxime Ripard wrote:
> > > > The display pipeline of the Allwinner A10 is involving several loosely
> > > > coupled components.
> > > >
> > > > Add a documentation for the bindings.
> > > >
> > > > Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
> > > > ---
> > > > .../bindings/display/sunxi/sun4i-drm.txt | 254 +++++++++++++++++++++
> > > > 1 file changed, 254 insertions(+)
> > > > create mode 100644 Documentation/devicetree/bindings/display/sunxi/sun4i-drm.txt
> > > >
> > > > diff --git a/Documentation/devicetree/bindings/display/sunxi/sun4i-drm.txt b/Documentation/devicetree/bindings/display/sunxi/sun4i-drm.txt
> > > > new file mode 100644
> > > > index 000000000000..378edb919eae
> > > > --- /dev/null
> > > > +++ b/Documentation/devicetree/bindings/display/sunxi/sun4i-drm.txt
> > > > @@ -0,0 +1,254 @@
> > > > +Allwinner A10 Display Pipeline
> > > > +==============================
> > > > +
> > > > +The Allwinner A10 Display pipeline is composed of several components
> > > > +that are going to be documented below:
> > > > +
> > > > +TV Encoder
> > > > +----------
> > > > +
> > > > +The TV Encoder supports the composite and VGA output. It is one end of
> > > > +the pipeline.
> > > > +
> > > > +Required properties:
> > > > + - compatible: value should be "allwinner,sun4i-a10-tv-encoder".
> > > > + - reg: base address and size of memory-mapped region
> > > > + - clocks: the clocks driving the TV encoder
> > > > + - resets: phandle to the reset controller driving the encoder
> > > > +
> > > > +- ports: A ports node with endpoint definitions as defined in
> > > > + Documentation/devicetree/bindings/media/video-interfaces.txt. The
> > > > + first port should be the input endpoint.
> > > > +
> > > > +TCON
> > > > +----
> > > > +
> > > > +The TCON acts as a timing controller for RGB, LVDS and TV interfaces.
> > > > +
> > > > +Required properties:
> > > > + - compatible: value should be "allwinner,sun5i-a13-tcon".
> > > > + - reg: base address and size of memory-mapped region
> > > > + - interrupts: interrupt associated to this IP
> > > > + - clocks: phandles to the clocks feeding the TCON. Three are needed:
> > > > + - 'ahb': the interface clocks
> > > > + - 'tcon-ch0': The clock driving the TCON channel 0
> > > > + - 'tcon-ch1': The clock driving the TCON channel 1
> > > > + - resets: phandles to the reset controllers driving the encoder
> > > > + - "lcd": the reset line for the TCON channel 0
> > > > +
> > > > + - clock-names: the clock names mentioned above
> > > > + - reset-names: the reset names mentioned above
> > > > + - clock-output-names: Name of the pixel clock created
> > > > +
> > > > +- ports: A ports node with endpoint definitions as defined in
> > > > + Documentation/devicetree/bindings/media/video-interfaces.txt. The
> > > > + first port should be the input endpoint, the second one the output
> > >
> > > The example shows 2 output endpoints. Your diagram shows up to 4
> > > outputs. The number should be how ever many could coexist in a given h/w
> > > design. In other words, I'm assuming all 4 can't be used simultaneously,
> > > but can all 4 be wired up in a h/w design and switched in s/w?
> > >
> > > Just be clear on the numbering.
> >
> > Yes, each TCON has two channels, the first one being usable for
> > RGB/LVDS, the second one for TV/VGA. HDMI is basically implemented
> > using an in-SoC RGB-to-HDMI bridge, so it would use the first channel
> > as well.
>
> So I think you should have 2 ports (1 per channel) and then 2 endpoints
> for 1st (RGB/LVDS/ExtBridge and HDMI) and 1 endpoint (TV/VGA) for 2nd
> port.

Yes, that makes sense.

> > I don't see how a particular design could use several devices on the
> > first channel, because they would share the same timings, and I don't
> > really see how it would work out.
> >
> > > > +
> > > > +Endpoints optional property:
> > > > + - allwinner,panel: boolean to indicate that the endpoint is a panel
> > >
> > > This can be determined by the endpoint not being TV Encoder (or HDMI).
> >
> > It wouldn't really scale if you start to consider the bridges
> > too. Then, you would have to duplicate and maintain a list of all the
> > bridges supported in Linux and a list of all the panels supported in
> > Linux, and try to match that to see if it's a panel, a bridge or an
> > element of our pipeline.
>
> So my concern is that no one else has needed this, so why do you? Based
> on the above, you know that a panel is always connected to port 0,
> endpoint 0. If it is an external bridge instead, then that can be
> determined when the bridge driver is bound.

Indeed, I'll try to use the panel and bridge API to retrieve the panel
and bridges drivers, and try to derive the information from that
instead of this DT property.

> > > > +Display Engine Backend
> > > > +----------------------
> > > > +
> > > > +The display engine backend exposes layers and sprites to the
> > > > +system.
> > > > +
> > > > +Required properties:
> > > > + - compatible: value must be one of:
> > > > + * allwinner,sun5i-a13-display-backend
> > > > + - reg: base address and size of the memory-mapped region.
> > > > + - clocks: phandles to the clocks feeding the frontend and backend
> > > > + * ahb: the backend interface clock
> > > > + * mod: the backend module clock
> > > > + * ram: the backend DRAM clock
> > > > + - clock-names: the clock names mentioned above
> > > > + - resets: phandles to the reset controllers driving the backend
> > > > +
> > > > +- ports: A ports node with endpoint definitions as defined in
> > > > + Documentation/devicetree/bindings/media/video-interfaces.txt. The
> > > > + first port should be the input endpoints, the second one the output
> > > > +
> > > > +Display Engine Frontend
> > > > +-----------------------
> > > > +
> > > > +The display engine frontend does formats conversion, scaling,
> > > > +deinterlacing and color space conversion.
> > > > +
> > > > +Required properties:
> > > > + - compatible: value must be one of:
> > > > + * allwinner,sun5i-a13-display-frontend
> > > > + - reg: base address and size of the memory-mapped region.
> > > > + - interrupts: interrupt associated to this IP
> > > > + - clocks: phandles to the clocks feeding the frontend and backend
> > > > + * ahb: the backend interface clock
> > > > + * mod: the backend module clock
> > > > + * ram: the backend DRAM clock
> > > > + - clock-names: the clock names mentioned above
> > > > + - resets: phandles to the reset controllers driving the backend
> > > > +
> > > > +Display Engine Pipeline
> > > > +-----------------------
> > > > +
> > > > +The display engine pipeline (and its entry point, since it can be
> > > > +either directly the backend or the frontend) is represented as an
> > > > +extra node.
> > > > +
> > > > +Required properties:
> > > > + - compatible: value must be one of:
> > > > + * allwinner,sun5i-a13-display-engine
> > > > + - allwinner,pipelines: list of phandle to the entry points of the
> > > > + pipelines (either to the frontend or backend)
> > >
> > > Seems like using FE or BE would be a function of your framebuffers'
> > > formats and shouldn't be defined in DT.
> >
> > Well, they are different IP blocks, so it should be defined in DT,
> > shouldn't it?
>
> They should, but allwinner,sun5i-a13-display-engine is not really an IP
> block. Again, what decides if you use the FE or not?

I'd say we would always want to use it, but we don't have support for
it right now. You can use the backend directly, and this is what we're
doing right now.

Thanks!
Maxime

--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]