From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751260AbcDPHsP (ORCPT ); Sat, 16 Apr 2016 03:48:15 -0400 Received: from down.free-electrons.com ([37.187.137.238]:47399 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751081AbcDPHsO convert rfc822-to-8bit (ORCPT ); Sat, 16 Apr 2016 03:48:14 -0400 Date: Sat, 16 Apr 2016 09:48:11 +0200 From: Boris Brezillon To: =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= Cc: linux-mtd@lists.infradead.org, Richard Weinberger , David Woodhouse , Brian Norris , linux-kernel@vger.kernel.org (open list) Subject: Re: [PATCH 08/12] mtd: nand: hisi504: set ECC algorithm based on DT info Message-ID: <20160416094811.0e8fcfff@bbrezillon> In-Reply-To: <1460750052-16285-9-git-send-email-zajec5@gmail.com> References: <1460750052-16285-1-git-send-email-zajec5@gmail.com> <1460750052-16285-9-git-send-email-zajec5@gmail.com> X-Mailer: Claws Mail 3.12.0 (GTK+ 2.24.28; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 15 Apr 2016 21:54:08 +0200 Rafał Miłecki wrote: > This is part of process deprecating NAND_ECC_SOFT_BCH (and switching to > enum nand_ecc_algo). > > Signed-off-by: Rafał Miłecki > --- > drivers/mtd/nand/hisi504_nand.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/mtd/nand/hisi504_nand.c b/drivers/mtd/nand/hisi504_nand.c > index 7bf844c..f917297 100644 > --- a/drivers/mtd/nand/hisi504_nand.c > +++ b/drivers/mtd/nand/hisi504_nand.c > @@ -768,6 +768,7 @@ static int hisi_nfc_probe(struct platform_device *pdev) > chip->chip_delay = HINFC504_CHIP_DELAY; > > chip->ecc.mode = of_get_nand_ecc_mode(np); > + chip->ecc.algo = of_get_nand_ecc_algo(np); I'm trying to remove those explicit ecc.xxx = of_get_nand_xxx() assignments and rely on the initialization done in nand_scan_ident() (see this series [1]). I'd like to apply the remaining patches in [1] before this series, which means this patch will be useless. No need to resend the series though, I'll skip this patch while applying, just wanted to let you know. > > buswidth = of_get_nand_bus_width(np); > if (buswidth == 16) [1]http://lkml.iu.edu/hypermail/linux/kernel/1604.0/00298.html -- Boris Brezillon, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com