From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751354AbcDPIB3 (ORCPT ); Sat, 16 Apr 2016 04:01:29 -0400 Received: from down.free-electrons.com ([37.187.137.238]:47487 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751040AbcDPIB2 convert rfc822-to-8bit (ORCPT ); Sat, 16 Apr 2016 04:01:28 -0400 Date: Sat, 16 Apr 2016 10:01:25 +0200 From: Boris Brezillon To: =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= Cc: linux-mtd@lists.infradead.org, Rob Herring , Frank Rowand , Grant Likely , devicetree@vger.kernel.org (open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE), linux-kernel@vger.kernel.org (open list) Subject: Re: [PATCH 11/12] of: mtd: drop support for NAND_ECC_SOFT_BCH as "soft_bch" mapping Message-ID: <20160416100125.272f6347@bbrezillon> In-Reply-To: <20160416100043.4b89e2a9@bbrezillon> References: <1460750052-16285-1-git-send-email-zajec5@gmail.com> <1460750052-16285-12-git-send-email-zajec5@gmail.com> <20160416100043.4b89e2a9@bbrezillon> X-Mailer: Claws Mail 3.12.0 (GTK+ 2.24.28; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 16 Apr 2016 10:00:43 +0200 Boris Brezillon wrote: > On Fri, 15 Apr 2016 21:54:11 +0200 > Rafał Miłecki wrote: > > > There isn't any difference between handling NAND_ECC_SOFT and > > NAND_ECC_SOFT_BCH now. What matters is the new field called "algo". > > Please note we're keeping backward DT compatibility. We are still > > treating "soft_bch" value as the one setting Hamming algorithm, it's > > just handled in of_get_nand_ecc_algo now. > > > > Signed-off-by: Rafał Miłecki > > --- > > drivers/of/of_mtd.c | 9 ++++++++- > > 1 file changed, 8 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/of/of_mtd.c b/drivers/of/of_mtd.c > > This series is getting rid of of_mtd{.c,.h}, so I'll move those changes > directly into nand_base.c when applying. Oops, here is the link: http://lkml.iu.edu/hypermail/linux/kernel/1604.0/00298.html > > > index 15d056e..a70a38c 100644 > > --- a/drivers/of/of_mtd.c > > +++ b/drivers/of/of_mtd.c > > @@ -22,7 +22,6 @@ static const char *nand_ecc_modes[] = { > > [NAND_ECC_HW] = "hw", > > [NAND_ECC_HW_SYNDROME] = "hw_syndrome", > > [NAND_ECC_HW_OOB_FIRST] = "hw_oob_first", > > - [NAND_ECC_SOFT_BCH] = "soft_bch", > > }; > > > > /** > > @@ -45,6 +44,14 @@ int of_get_nand_ecc_mode(struct device_node *np) > > if (!strcasecmp(pm, nand_ecc_modes[i])) > > return i; > > > > + /* > > + * For backward compatibility we support few obsoleted values that don't > > + * have their mappings into nand_ecc_modes_t anymore (they were merged > > + * with other enums). > > + */ > > + if (!strcasecmp(pm, "soft_bch")) > > + return NAND_ECC_SOFT; > > + > > return -ENODEV; > > } > > EXPORT_SYMBOL_GPL(of_get_nand_ecc_mode); > > > -- Boris Brezillon, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com