From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751799AbcDQJdu (ORCPT ); Sun, 17 Apr 2016 05:33:50 -0400 Received: from mail-pf0-f180.google.com ([209.85.192.180]:35401 "EHLO mail-pf0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751481AbcDQJds (ORCPT ); Sun, 17 Apr 2016 05:33:48 -0400 Date: Sun, 17 Apr 2016 02:33:45 -0700 From: Dmitry Torokhov To: Jonathan Cameron Cc: Ksenija Stanojevic , knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] iio: adc: set INPUT_PROP_DIRECT Message-ID: <20160417093345.GA23092@dtor-ws> References: <7838d255676f6f778bf9710454f632cd68a35185.1460316098.git.ksenija.stanojevic@gmail.com> <571291F8.1010804@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <571291F8.1010804@kernel.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Apr 16, 2016 at 08:26:48PM +0100, Jonathan Cameron wrote: > On 10/04/16 20:22, Ksenija Stanojevic wrote: > > Set INPUT_PROP_DIRECT to indicate that it is a touchscreen on the > > device to help userspace classify it. > > > > Signed-off-by: Ksenija Stanojevic > Sounds correct to me. Dmitry? Acked-by: Dmitry Torokhov > > --- > > drivers/iio/adc/mxs-lradc.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/iio/adc/mxs-lradc.c b/drivers/iio/adc/mxs-lradc.c > > index 07287af..e4c4c5c 100644 > > --- a/drivers/iio/adc/mxs-lradc.c > > +++ b/drivers/iio/adc/mxs-lradc.c > > @@ -1127,6 +1127,7 @@ static int mxs_lradc_ts_register(struct mxs_lradc *lradc) > > __set_bit(EV_ABS, input->evbit); > > __set_bit(EV_KEY, input->evbit); > > __set_bit(BTN_TOUCH, input->keybit); > > + __set_bit(INPUT_PROP_DIRECT, input->propbit); > > input_set_abs_params(input, ABS_X, 0, LRADC_SINGLE_SAMPLE_MASK, 0, 0); > > input_set_abs_params(input, ABS_Y, 0, LRADC_SINGLE_SAMPLE_MASK, 0, 0); > > input_set_abs_params(input, ABS_PRESSURE, 0, LRADC_SINGLE_SAMPLE_MASK, > > > -- Dmitry