From: Mark Brown <broonie@kernel.org>
To: Xing Zheng <zhengxing@rock-chips.com>
Cc: linux-rockchip@lists.infradead.org, heiko@sntech.de,
Adam.Thomson@diasemi.com, sugar.zhang@rock-chips.com,
jay.xu@rock-chips.com, Liam Girdwood <lgirdwood@gmail.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] ASoC: jack: Add a jack detect callback via codec
Date: Mon, 18 Apr 2016 10:22:18 +0100 [thread overview]
Message-ID: <20160418092218.GL3217@sirena.org.uk> (raw)
In-Reply-To: <1460967452-24574-2-git-send-email-zhengxing@rock-chips.com>
[-- Attachment #1: Type: text/plain, Size: 673 bytes --]
On Mon, Apr 18, 2016 at 04:17:30PM +0800, Xing Zheng wrote:
> This patch add a callback when a codec have the jack detect feature.
> +void snd_soc_jack_codec_detect(struct snd_soc_codec *codec,
> + struct snd_soc_jack *jack)
> +{
> + if (codec && codec->driver && codec->driver->detect_jack)
> + codec->driver->detect_jack(codec, jack);
> +}
> +EXPORT_SYMBOL_GPL(snd_soc_jack_codec_detect);
I've no idea what this is supposed to do sorry, you need a much better
changelog and probably also a restructuring of the code. This says it
is adding a callback but it doesn't do that, it adds an export of a
function that calls an operation in a driver with no explanation.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2016-04-18 9:23 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-18 8:17 [PATCH 0/3] Add support simple-card parse jack detection via external codec Xing Zheng
2016-04-18 8:17 ` [PATCH 1/3] ASoC: jack: Add a jack detect callback via codec Xing Zheng
2016-04-18 9:22 ` Mark Brown [this message]
2016-04-18 9:43 ` Xing Zheng
2016-04-18 9:53 ` Mark Brown
2016-04-18 10:03 ` Xing Zheng
2016-04-18 10:20 ` Xing Zheng
2016-04-18 11:46 ` Mark Brown
2016-04-18 16:40 ` Dylan Reid
2016-04-18 8:17 ` [PATCH 2/3] ASoC: simple-card: Add support jack detection " Xing Zheng
2016-04-21 14:19 ` Rob Herring
2016-04-22 1:17 ` Xing Zheng
2016-04-22 9:22 ` Mark Brown
2016-04-22 16:37 ` [alsa-devel] " Jeremy McDermond
2016-04-25 12:55 ` Mark Brown
2016-04-25 18:17 ` Jeremy McDermond
2016-04-22 16:40 ` Jeremy McDermond
2016-04-18 8:17 ` [PATCH 3/3] ASoC: da7219: Add detect_jack callback in the snd_soc_codec_driver Xing Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160418092218.GL3217@sirena.org.uk \
--to=broonie@kernel.org \
--cc=Adam.Thomson@diasemi.com \
--cc=alsa-devel@alsa-project.org \
--cc=heiko@sntech.de \
--cc=jay.xu@rock-chips.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=perex@perex.cz \
--cc=sugar.zhang@rock-chips.com \
--cc=tiwai@suse.com \
--cc=zhengxing@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox