From: Mark Brown <broonie@kernel.org>
To: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Cc: Sangbeom Kim <sbkim73@samsung.com>,
Liam Girdwood <lgirdwood@gmail.com>,
linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Subject: Re: [PATCH] regulator: s2mps11: Remove unused set_voltage_time_sel
Date: Mon, 18 Apr 2016 10:57:13 +0100 [thread overview]
Message-ID: <20160418095713.GO3217@sirena.org.uk> (raw)
In-Reply-To: <1460965378-5256-1-git-send-email-k.kozlowski@samsung.com>
[-- Attachment #1: Type: text/plain, Size: 560 bytes --]
On Mon, Apr 18, 2016 at 09:42:58AM +0200, Krzysztof Kozlowski wrote:
> On S2MPS11 and S2MPS14 devices the default implementation of
> set_voltage_time_sel() for LDO regulators was not doing anything useful
> because users did not provide ramp delay in Device Tree so the
> set_voltage_time_sel() exited with status 0. This could be seen in
> dmesg, e.g. on Odroid XU4:
That's not the bug, the bug is that the driver is providing the
operation without providing a non-zero value for it. The device tree
configuration is to override what the driver is doing.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2016-04-18 9:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-18 7:42 [PATCH] regulator: s2mps11: Remove unused set_voltage_time_sel Krzysztof Kozlowski
2016-04-18 9:57 ` Mark Brown [this message]
2016-04-18 10:36 ` Krzysztof Kozlowski
2016-04-18 11:00 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160418095713.GO3217@sirena.org.uk \
--to=broonie@kernel.org \
--cc=b.zolnierkie@samsung.com \
--cc=k.kozlowski@samsung.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=sbkim73@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox