From: Peter Chen <hzpeterchen@gmail.com>
To: Roger Quadros <rogerq@ti.com>
Cc: Peter.Chen@nxp.com, balbi@kernel.org, gregkh@linuxfoundation.org,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v7 3/3] usb: otg-fsm: Prevent build warning "VDBG" redefined
Date: Tue, 19 Apr 2016 16:21:46 +0800 [thread overview]
Message-ID: <20160419082146.GB15789@shlinux2.ap.freescale.net> (raw)
In-Reply-To: <5704B730.2040105@ti.com>
On Wed, Apr 06, 2016 at 10:13:52AM +0300, Roger Quadros wrote:
> On 06/04/16 09:46, Peter Chen wrote:
> > On Tue, Apr 05, 2016 at 04:48:19PM +0300, Roger Quadros wrote:
> >> Peter,
> >>
> >> On 05/04/16 15:52, Roger Quadros wrote:
> >>> Peter,
> >>>
> >>> On 05/04/16 11:52, Peter Chen wrote:
> >>>> On Thu, Mar 31, 2016 at 12:41:19PM +0300, Roger Quadros wrote:
> >>>>> If usb/otg-fsm.h and usb/composite.h are included together
> >>>>> then it results in the build warning [1].
> >>>>>
> >>>>> Prevent that by using dev_vdbg() instead.
> >>>>>
> >>>>
> >>>> After considering it more, I think it may not be a good solution
> >>>> that we delete VDBG at one header file, but keep it at another
> >>>> one. In future, we may add VDBG at another file, and cause the
> >>>> same problem. In fact, I find VDBG is defined at several files
> >>>> in USB folder (and only at USB folder), I plan to replace them
> >>>> with standard one (dev_vdbg) together.
> >>>
> >>> OK, please ignore this patch then.
> >>
> >> On second thoughts can you please retain this patch and post the
> >> VDBG removal from composite.h cleanup separately?
> >>
> >
> > I find the struct usb_otg has a struct device pointer, and you changes
> > all fsm stuffs under struct usb_otg (like otg.fsm) in your later patches,
> > then, would you please refine this patch that just using otg->dev for
> > print and move VDBG to phy-fsl-usb.c, of course, you need to move this
> > patch in that patch series.
>
> OK. I'll rework this patch and include it in the otg series.
>
I have already queued your 1st and 2nd patch at my tree.
--
Best Regards,
Peter Chen
next prev parent reply other threads:[~2016-04-19 8:29 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-30 9:56 [PATCH v6 0/3] usb: otg-fsm: Add documentation and some trivial cleanups Roger Quadros
2016-03-30 9:56 ` [PATCH v6 1/3] usb: otg-fsm: Add documentation for struct otg_fsm Roger Quadros
2016-03-30 9:56 ` [PATCH v6 2/3] usb: otg-fsm: support multiple instances Roger Quadros
2016-03-30 9:56 ` [PATCH v6 3/3] usb: otg-fsm: Prevent build warning "VDBG" redefined Roger Quadros
2016-03-31 9:41 ` [PATCH v7 " Roger Quadros
2016-04-05 8:52 ` Peter Chen
2016-04-05 12:52 ` Roger Quadros
2016-04-05 13:48 ` Roger Quadros
2016-04-06 6:46 ` Peter Chen
2016-04-06 7:13 ` Roger Quadros
2016-04-19 8:21 ` Peter Chen [this message]
2016-03-31 7:08 ` [PATCH v6 0/3] usb: otg-fsm: Add documentation and some trivial cleanups Peter Chen
2016-03-31 9:40 ` Roger Quadros
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160419082146.GB15789@shlinux2.ap.freescale.net \
--to=hzpeterchen@gmail.com \
--cc=Peter.Chen@nxp.com \
--cc=balbi@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=rogerq@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox