From: Will Deacon <will.deacon@arm.com>
To: Matt Fleming <matt@codeblueprint.co.uk>
Cc: Arnd Bergmann <arnd@arndb.de>,
Steve Capper <steve.capper@arm.com>,
Ard Biesheuvel <ard.biesheuvel@linaro.org>,
David Daney <david.daney@cavium.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Leif Lindholm <leif.lindholm@linaro.org>,
Dan Williams <dan.j.williams@intel.com>,
linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] efi: ARM: avoid warning about phys_addr_t cast
Date: Tue, 19 Apr 2016 14:46:17 +0100 [thread overview]
Message-ID: <20160419134616.GD21110@arm.com> (raw)
In-Reply-To: <20160418211233.GZ2829@codeblueprint.co.uk>
On Mon, Apr 18, 2016 at 10:12:33PM +0100, Matt Fleming wrote:
> On Mon, 18 Apr, at 10:34:19AM, Arnd Bergmann wrote:
> > memblock_remove() takes a phys_addr_t, which may be narrower than 64 bits,
> > causing a harmless warning:
> >
> > drivers/firmware/efi/arm-init.c: In function 'reserve_regions':
> > include/linux/kernel.h:29:20: error: large integer implicitly truncated to unsigned type [-Werror=overflow]
> > #define ULLONG_MAX (~0ULL)
> > ^
> > drivers/firmware/efi/arm-init.c:152:21: note: in expansion of macro 'ULLONG_MAX'
> > memblock_remove(0, ULLONG_MAX);
> >
> > This adds an explicit typecast to avoid the warning
> >
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> > Fixes: 500899c2cc3e ("efi: ARM/arm64: ignore DT memory nodes instead of removing them")
> > ---
> > drivers/firmware/efi/arm-init.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Will, this one is for you.
>
> Reviewed-by: Matt Fleming <matt@codeblueprint.co.uk>
Thanks, I'll throw it on the pile.
Will
prev parent reply other threads:[~2016-04-19 13:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-18 8:34 [PATCH] efi: ARM: avoid warning about phys_addr_t cast Arnd Bergmann
2016-04-18 8:36 ` Ard Biesheuvel
2016-04-18 21:12 ` Matt Fleming
2016-04-19 13:46 ` Will Deacon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160419134616.GD21110@arm.com \
--to=will.deacon@arm.com \
--cc=ard.biesheuvel@linaro.org \
--cc=arnd@arndb.de \
--cc=catalin.marinas@arm.com \
--cc=dan.j.williams@intel.com \
--cc=david.daney@cavium.com \
--cc=leif.lindholm@linaro.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=matt@codeblueprint.co.uk \
--cc=steve.capper@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox