From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933783AbcDSRPW (ORCPT ); Tue, 19 Apr 2016 13:15:22 -0400 Received: from foss.arm.com ([217.140.101.70]:41791 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932910AbcDSRPS (ORCPT ); Tue, 19 Apr 2016 13:15:18 -0400 Date: Tue, 19 Apr 2016 18:15:12 +0100 From: Lorenzo Pieralisi To: Sudeep Holla Cc: Jisheng Zhang , mark.rutland@arm.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] drivers: firmware: psci: add __init mark to psci_dt_cpu_init_idle Message-ID: <20160419171511.GA2939@red-moon> References: <1458657329-2484-1-git-send-email-jszhang@marvell.com> <20160419150555.GB15458@red-moon> <57164CC6.1010201@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <57164CC6.1010201@arm.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 19, 2016 at 04:20:38PM +0100, Sudeep Holla wrote: > > > On 19/04/16 16:05, Lorenzo Pieralisi wrote: > >Hi Jisheng, > > > >On Tue, Mar 22, 2016 at 10:35:29PM +0800, Jisheng Zhang wrote: > >>psci_dt_cpu_init_idle() and psci_cpu_init_idle() are not needed after > >>booting, so mark them as __init. > >> > > On the other hand, when I was trying to reuse arm_cpuidle_init to > support ACPI LPIs, I found that we may need to remove __init tag on it > as it gets called by hotplug notifiers in ACPI context. > > I am not objecting this change, just mentioning with the hope to get > solution to the above issue. Yep, good point, it is not strictly necessary to merge it either and I would avoid churning out changes given that we know we will require to remove those __init tags anyway, so patch dropped. Lorenzo