From: Stephen Boyd <sboyd@codeaurora.org>
To: Jose Abreu <Jose.Abreu@synopsys.com>
Cc: Vineet Gupta <Vineet.Gupta1@synopsys.com>,
linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org,
linux-snps-arc@lists.infradead.org, CARLOS.PALMINHA@synopsys.com,
Alexey.Brodkin@synopsys.com, mturquette@baylibre.com
Subject: Re: [RESEND PATCH v4] clk/axs10x: Add I2S PLL clock driver
Date: Tue, 19 Apr 2016 18:54:51 -0700 [thread overview]
Message-ID: <20160420015451.GH15324@codeaurora.org> (raw)
In-Reply-To: <5715F6AC.7090501@synopsys.com>
On 04/19, Jose Abreu wrote:
>
> @Stephen: can you give some input so that I can submit a v6?
>
I don't prefer putting the second register in the same DT node,
but that's really up to the DT reviewers to approve such a
design. The current binding has been acked by Rob right?
Assuming the new binding is acked/reviewed then that solution is
fine.
Otherwise, I still prefer two DTS files for the two different FPGA
versions. At the least, please use ioremap for any pointers that
you readl/writel here.
Beyond that, we should have a fixed rate source clk somewhere in
the software view of the clk tree, because that reflects reality.
Hardcoding the parent rate in the structure works, but doesn't
properly express the clk tree.
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2016-04-20 1:54 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-11 10:41 [RESEND PATCH v4] clk/axs10x: Add I2S PLL clock driver Jose Abreu
2016-04-11 16:47 ` Alexey Brodkin
2016-04-11 22:03 ` sboyd
2016-04-15 12:08 ` Alexey Brodkin
2016-04-15 23:38 ` sboyd
2016-04-15 23:46 ` Stephen Boyd
2016-04-18 10:30 ` Jose Abreu
2016-04-18 11:49 ` Vineet Gupta
2016-04-19 9:13 ` Jose Abreu
2016-04-20 1:54 ` Stephen Boyd [this message]
2016-04-20 9:47 ` Jose Abreu
2016-04-20 16:12 ` Alexey Brodkin
2016-04-21 9:51 ` Jose Abreu
2016-04-21 12:18 ` Alexey Brodkin
2016-04-21 13:10 ` Jose Abreu
2016-04-21 14:15 ` Alexey Brodkin
2016-04-22 5:50 ` Vineet Gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160420015451.GH15324@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=Alexey.Brodkin@synopsys.com \
--cc=CARLOS.PALMINHA@synopsys.com \
--cc=Jose.Abreu@synopsys.com \
--cc=Vineet.Gupta1@synopsys.com \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-snps-arc@lists.infradead.org \
--cc=mturquette@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).