* [PATCH] mcb: Fixed bar number assignment for the gdd
@ 2016-04-20 6:35 Andreas Werner
2016-04-20 8:57 ` Johannes Thumshirn
0 siblings, 1 reply; 2+ messages in thread
From: Andreas Werner @ 2016-04-20 6:35 UTC (permalink / raw)
To: morbidrsa; +Cc: linux-kernel, jthumshirn
The bar number is found in reg2 within the gdd. Therefore
we need to change the assigment from reg1 to reg2 which
is the correct location.
Signed-off-by: Andreas Werner <andreas.werner@men.de>
---
drivers/mcb/mcb-parse.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mcb/mcb-parse.c b/drivers/mcb/mcb-parse.c
index 0049269..b0155b0 100644
--- a/drivers/mcb/mcb-parse.c
+++ b/drivers/mcb/mcb-parse.c
@@ -57,7 +57,7 @@ static int chameleon_parse_gdd(struct mcb_bus *bus,
mdev->id = GDD_DEV(reg1);
mdev->rev = GDD_REV(reg1);
mdev->var = GDD_VAR(reg1);
- mdev->bar = GDD_BAR(reg1);
+ mdev->bar = GDD_BAR(reg2);
mdev->group = GDD_GRP(reg2);
mdev->inst = GDD_INS(reg2);
--
2.6.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] mcb: Fixed bar number assignment for the gdd
2016-04-20 6:35 [PATCH] mcb: Fixed bar number assignment for the gdd Andreas Werner
@ 2016-04-20 8:57 ` Johannes Thumshirn
0 siblings, 0 replies; 2+ messages in thread
From: Johannes Thumshirn @ 2016-04-20 8:57 UTC (permalink / raw)
To: Andreas Werner; +Cc: morbidrsa, linux-kernel, jthumshirn
On Wed, Apr 20, 2016 at 08:35:47AM +0200, Andreas Werner wrote:
> The bar number is found in reg2 within the gdd. Therefore
> we need to change the assigment from reg1 to reg2 which
> is the correct location.
>
> Signed-off-by: Andreas Werner <andreas.werner@men.de>
> ---
> drivers/mcb/mcb-parse.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mcb/mcb-parse.c b/drivers/mcb/mcb-parse.c
> index 0049269..b0155b0 100644
> --- a/drivers/mcb/mcb-parse.c
> +++ b/drivers/mcb/mcb-parse.c
> @@ -57,7 +57,7 @@ static int chameleon_parse_gdd(struct mcb_bus *bus,
> mdev->id = GDD_DEV(reg1);
> mdev->rev = GDD_REV(reg1);
> mdev->var = GDD_VAR(reg1);
> - mdev->bar = GDD_BAR(reg1);
> + mdev->bar = GDD_BAR(reg2);
> mdev->group = GDD_GRP(reg2);
> mdev->inst = GDD_INS(reg2);
>
> --
> 2.6.2
>
Applied, thanks.
--
Johannes Thumshirn Storage
jthumshirn@suse.de +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-04-20 8:58 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-04-20 6:35 [PATCH] mcb: Fixed bar number assignment for the gdd Andreas Werner
2016-04-20 8:57 ` Johannes Thumshirn
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).