From: Tejun Heo <tj@kernel.org>
To: serge.hallyn@ubuntu.com
Cc: linux-kernel@vger.kernel.org, adityakali@google.com,
linux-api@vger.kernel.org, containers@lists.linux-foundation.org,
cgroups@vger.kernel.org, akpm@linux-foundation.org,
ebiederm@xmission.com, gregkh@linuxfoundation.org,
lizefan@huawei.com, hannes@cmpxchg.org
Subject: Re: [PATCH 1/2] kernfs_path_from_node_locked: don't overwrite nlen
Date: Wed, 20 Apr 2016 15:43:13 -0400 [thread overview]
Message-ID: <20160420194313.GA4775@htj.duckdns.org> (raw)
In-Reply-To: <1460923472-29370-2-git-send-email-serge.hallyn@ubuntu.com>
On Sun, Apr 17, 2016 at 03:04:31PM -0500, serge.hallyn@ubuntu.com wrote:
> From: Serge Hallyn <serge.hallyn@ubuntu.com>
>
> We've calculated @len to be the bytes we need for '/..' entries from
> @kn_from to the common ancestor, and calculated @nlen to be the extra
> bytes we need to get from the common ancestor to @kn_to. We use them
> as such at the end. But in the loop copying the actual entries, we
> overwrite @nlen. Use a temporary variable for that instead.
>
> Without this, the return length, when the buffer is large enough, is
> wrong. (When the buffer is NULL or too small, the returned value is
> correct. The buffer contents are also correct.)
>
> Interestingly, no callers of this function are affected by this as of
> yet. However the upcoming cgroup_show_path() will be.
>
> Signed-off-by: Serge Hallyn <serge.hallyn@ubuntu.com>
Acked-by: Tejun Heo <tj@kernel.org>
Greg, can you please pick this one up for v4.6?
Thanks.
--
tejun
next prev parent reply other threads:[~2016-04-20 19:43 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-17 20:04 Show virtualized dentry root in mountinfo for cgroupfs serge.hallyn
2016-04-17 20:04 ` [PATCH 1/2] kernfs_path_from_node_locked: don't overwrite nlen serge.hallyn
2016-04-20 19:43 ` Tejun Heo [this message]
2016-05-02 16:32 ` Tejun Heo
2016-05-02 16:41 ` Greg KH
2016-04-17 20:04 ` [PATCH 2/2] mountinfo: implement show_path for kernfs and cgroup serge.hallyn
2016-04-18 4:11 ` Serge E. Hallyn
2016-04-18 5:29 ` [PATCH 3/2] cgroup_show_path: use a new helper to get current cgns css_set Serge E. Hallyn
2016-04-29 21:42 ` Serge E. Hallyn
2016-05-02 16:35 ` Tejun Heo
2016-05-03 14:26 ` Serge E. Hallyn
2016-04-19 1:12 ` [PATCH 2/2] mountinfo: implement show_path for kernfs and cgroup Eric W. Biederman
2016-04-19 1:44 ` Serge E. Hallyn
2016-04-19 4:05 ` Serge E. Hallyn
2016-04-26 2:42 ` Serge E. Hallyn
2016-04-26 10:29 ` Karel Zak
2016-04-26 14:36 ` Serge E. Hallyn
2016-05-02 16:33 ` Tejun Heo
2016-05-02 16:34 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160420194313.GA4775@htj.duckdns.org \
--to=tj@kernel.org \
--cc=adityakali@google.com \
--cc=akpm@linux-foundation.org \
--cc=cgroups@vger.kernel.org \
--cc=containers@lists.linux-foundation.org \
--cc=ebiederm@xmission.com \
--cc=gregkh@linuxfoundation.org \
--cc=hannes@cmpxchg.org \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan@huawei.com \
--cc=serge.hallyn@ubuntu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).