From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751552AbcDUCNL (ORCPT ); Wed, 20 Apr 2016 22:13:11 -0400 Received: from mail-pa0-f45.google.com ([209.85.220.45]:34407 "EHLO mail-pa0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751001AbcDUCNJ (ORCPT ); Wed, 20 Apr 2016 22:13:09 -0400 Date: Thu, 21 Apr 2016 11:14:40 +0900 From: Sergey Senozhatsky To: Joe Perches Cc: Sergey Senozhatsky , Andrew Morton , Jan Kara , Petr Mladek , Tejun Heo , Tetsuo Handa , linux-kernel@vger.kernel.org, Byungchul Park , Sergey Senozhatsky Subject: Re: [PATCH v11 0/3] printk: Make printk() completely async Message-ID: <20160421021440.GB655@swordfish> References: <1460050307-3718-1-git-send-email-sergey.senozhatsky@gmail.com> <20160416025529.GA567@swordfish> <1460785489.19090.71.camel@perches.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1460785489.19090.71.camel@perches.com> User-Agent: Mutt/1.6.0 (2016-04-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On (04/15/16 22:44), Joe Perches wrote: [..] > > Sir, is there anything else you want me to improve in this patch set? > > I'm not sir, but my preference would be to move as much of the > async/thread functionality as possible into a separate file. hm, we are talking about some 50-60 lines of code in total (seems that the patch set adds more comments than code), but your point is interesting. let's say, if there will be more opinions that it better land in async_printk.{c,h} files, then I'll take a look on it. how does it sound? -ss