From: Matt Fleming <matt@codeblueprint.co.uk>
To: Borislav Petkov <bp@alien8.de>
Cc: linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org,
Robert Elliott <elliott@hpe.com>
Subject: Re: [PATCH] x86/efi: Remove the always true EFI_DEBUG symbol
Date: Thu, 21 Apr 2016 13:48:20 +0100 [thread overview]
Message-ID: <20160421124820.GF2829@codeblueprint.co.uk> (raw)
In-Reply-To: <20160421124542.GF28821@pd.tnic>
On Thu, 21 Apr, at 02:45:42PM, Borislav Petkov wrote:
> On Thu, Apr 21, 2016 at 12:09:30PM +0100, Matt Fleming wrote:
> > This symbol is always set which makes it useless. Additionally we have
> > a kernel command-line switch, efi=debug, which actually controls the
> > printing of the memory map.
> >
> > Reported-by: Robert Elliott <elliott@hpe.com>
> > Cc: Borislav Petkov <bp@alien8.de>
> > Signed-off-by: Matt Fleming <matt@codeblueprint.co.uk>
> > ---
> > arch/x86/platform/efi/efi.c | 4 ----
> > 1 file changed, 4 deletions(-)
>
> Acked-by: Borislav Petkov <bp@suse.de>
>
> Btw, there's also
>
> arch/ia64/kernel/efi.c:45:#define EFI_DEBUG 0
> arch/ia64/kernel/efi.c:399:#if EFI_DEBUG
> arch/ia64/kernel/efi.c:559:#if EFI_DEBUG
>
> I'm assuming you want to put that behind "if (efi_enabled(EFI_DBG))" too...
Hmm.. Yes, that'd be a good idea. I am in the process of setting up an
Itanium box or two for runtime EFI testing, so I'll make a note of
this task.
prev parent reply other threads:[~2016-04-21 12:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-21 11:09 [PATCH] x86/efi: Remove the always true EFI_DEBUG symbol Matt Fleming
2016-04-21 12:45 ` Borislav Petkov
2016-04-21 12:48 ` Matt Fleming [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160421124820.GF2829@codeblueprint.co.uk \
--to=matt@codeblueprint.co.uk \
--cc=bp@alien8.de \
--cc=elliott@hpe.com \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox