From: Mark Brown <broonie@kernel.org>
To: Richard Fitzgerald <rf@opensource.wolfsonmicro.com>
Cc: lgirdwood@gmail.com, linux-kernel@vger.kernel.org,
patches@opensource.wolfsonmicro.com
Subject: Re: [PATCH v2] regulator: core: Add debugfs to show constraint flags
Date: Thu, 21 Apr 2016 16:06:56 +0100 [thread overview]
Message-ID: <20160421150656.GP3217@sirena.org.uk> (raw)
In-Reply-To: <1461242174-11310-1-git-send-email-rf@opensource.wolfsonmicro.com>
[-- Attachment #1: Type: text/plain, Size: 601 bytes --]
On Thu, Apr 21, 2016 at 01:36:14PM +0100, Richard Fitzgerald wrote:
> + ret = snprintf(buf, PAGE_SIZE,
> + "always_on: %u\nboot_on: %u\napply_uV: %u\nramp_disable: %u\n"
> + "soft_start: %u\npull_down: %u\nover_current_protection: %u\n",
> + !!c->always_on,
> + !!c->boot_on,
> + !!c->apply_uV,
> + !!c->ramp_disable,
> + !!c->soft_start,
> + !!c->pull_down,
> + !!c->over_current_protection);
Can we try for legibility please? Trying to cram everything onto the
minimum number of lines really doesn't help and the !!s either do
nothing or will end up obscuring information down the line.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
prev parent reply other threads:[~2016-04-21 15:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-21 12:36 [PATCH v2] regulator: core: Add debugfs to show constraint flags Richard Fitzgerald
2016-04-21 15:06 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160421150656.GP3217@sirena.org.uk \
--to=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@opensource.wolfsonmicro.com \
--cc=rf@opensource.wolfsonmicro.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox