From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752553AbcDUUiO (ORCPT <rfc822;w@1wt.eu>);
	Thu, 21 Apr 2016 16:38:14 -0400
Received: from mail.skyhub.de ([78.46.96.112]:33548 "EHLO mail.skyhub.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751240AbcDUUiN (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Thu, 21 Apr 2016 16:38:13 -0400
Date: Thu, 21 Apr 2016 22:37:52 +0200
From: Borislav Petkov <bp@alien8.de>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Peter Zijlstra <a.p.zijlstra@chello.nl>,
        Ingo Molnar <mingo@redhat.com>, linux-kernel@vger.kernel.org,
        vince@deater.net, eranian@google.com,
        Arnaldo Carvalho de Melo <acme@infradead.org>,
        Mathieu Poirier <mathieu.poirier@linaro.org>
Subject: Re: [PATCH v1 2/5] perf/x86/intel/pt: IP filtering register/cpuid
 bits
Message-ID: <20160421203752.GL28821@pd.tnic>
References: <1461251823-12416-1-git-send-email-alexander.shishkin@linux.intel.com>
 <1461251823-12416-3-git-send-email-alexander.shishkin@linux.intel.com>
 <20160421174813.GA29639@pd.tnic>
 <alpine.DEB.2.11.1604212051020.3941@nanos>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <alpine.DEB.2.11.1604212051020.3941@nanos>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Apr 21, 2016 at 08:55:38PM +0200, Thomas Gleixner wrote:
> I have to disagree here. The MSRs itself can really go into msr-index.h while
> the bit definitions might go elsewhere. What's wrong with having all MSRs at a
> central place?

Same reason as for pci_ids.h - to contain only MSRs which are used in
multiple compilation units.

-- 
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.