From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752560AbcDUUVA (ORCPT ); Thu, 21 Apr 2016 16:21:00 -0400 Received: from down.free-electrons.com ([37.187.137.238]:45337 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751718AbcDUUU7 convert rfc822-to-8bit (ORCPT ); Thu, 21 Apr 2016 16:20:59 -0400 Date: Thu, 21 Apr 2016 22:20:56 +0200 From: Boris Brezillon To: =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= , Greg Kroah-Hartman Cc: linux-mtd@lists.infradead.org, Eva Rachel Retuya , Brian Norris , Manuel =?UTF-8?B?UMOpZ291cmk=?= =?UTF-8?B?w6ktR29ubmFyZA==?= , Janani Ravichandran , devel@driverdev.osuosl.org (open list:STAGING SUBSYSTEM), linux-kernel@vger.kernel.org (open list) Subject: Re: [PATCH V3 05/11] staging: mt29f_spinand: set ECC algorithm explicitly Message-ID: <20160421222056.1deb7d13@bbrezillon> In-Reply-To: <1460926387-9563-6-git-send-email-zajec5@gmail.com> References: <1460913104-27388-1-git-send-email-zajec5@gmail.com> <1460926387-9563-1-git-send-email-zajec5@gmail.com> <1460926387-9563-6-git-send-email-zajec5@gmail.com> X-Mailer: Claws Mail 3.12.0 (GTK+ 2.24.28; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Greg, On Sun, 17 Apr 2016 22:53:01 +0200 Rafał Miłecki wrote: > This is part of process deprecating NAND_ECC_SOFT_BCH (and switching to > enum nand_ecc_algo). Do you mind if I take this patch through the NAND tree in order to avoid dependency problems? > > Signed-off-by: Rafał Miłecki > --- > drivers/staging/mt29f_spinand/mt29f_spinand.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/staging/mt29f_spinand/mt29f_spinand.c b/drivers/staging/mt29f_spinand/mt29f_spinand.c > index f503699..e389009 100644 > --- a/drivers/staging/mt29f_spinand/mt29f_spinand.c > +++ b/drivers/staging/mt29f_spinand/mt29f_spinand.c > @@ -900,6 +900,7 @@ static int spinand_probe(struct spi_device *spi_nand) > chip->ecc.write_page = spinand_write_page_hwecc; > #else > chip->ecc.mode = NAND_ECC_SOFT; > + chip->ecc.algo = NAND_ECC_HAMMING; > if (spinand_disable_ecc(spi_nand) < 0) > dev_info(&spi_nand->dev, "%s: disable ecc failed!\n", > __func__); -- Boris Brezillon, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com