From: Mark Brown <broonie@kernel.org>
To: Richard Fitzgerald <rf@opensource.wolfsonmicro.com>
Cc: lgirdwood@gmail.com, patches@opensource.wolfsonmicro.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] regulator: core: Add debugfs for regulator always_on flag
Date: Fri, 22 Apr 2016 14:57:09 +0100 [thread overview]
Message-ID: <20160422135709.GE3217@sirena.org.uk> (raw)
In-Reply-To: <1461331982-30960-1-git-send-email-rf@opensource.wolfsonmicro.com>
[-- Attachment #1: Type: text/plain, Size: 810 bytes --]
On Fri, Apr 22, 2016 at 02:33:02PM +0100, Richard Fitzgerald wrote:
> This patch adds a debugfs file for the always_on flag in struct regulator.
> It's useful for debugging to be able to view the state of this flag and
> as it's set by logic inside the regulator core it doesn't necessarily have
> the same value as the always_on flag in constraints.
Why not include this in the same file as the rest of the constraints?
Or why not have one file per constraint (which would be easier for
scripts)?
> + ret = snprintf(buf, PAGE_SIZE, "always_on: %u\n", regulator->always_on);
> + debugfs_create_file("always_on", 0444, regulator->debugfs,
It seems to be formatted as though it's going to end up in the same file
but it's a separate file so instead it's just repeating the name of the
file inside the file.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2016-04-22 13:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-22 13:33 [PATCH] regulator: core: Add debugfs for regulator always_on flag Richard Fitzgerald
2016-04-22 13:57 ` Mark Brown [this message]
2016-04-22 14:40 ` Richard Fitzgerald
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160422135709.GE3217@sirena.org.uk \
--to=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@opensource.wolfsonmicro.com \
--cc=rf@opensource.wolfsonmicro.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox