public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] documentation: ACQUIRE applies to loads, RELEASE applies to stores
@ 2016-04-22 10:41 Will Deacon
  2016-04-22 14:32 ` Peter Zijlstra
  0 siblings, 1 reply; 3+ messages in thread
From: Will Deacon @ 2016-04-22 10:41 UTC (permalink / raw)
  To: linux-kernel; +Cc: Will Deacon, Paul E. McKenney, Peter Zijlstra

For compound atomics performing both a load and a store operation, make
it clear that _acquire and _release variants refer only to the load and
store portions of compound atomic. For example, xchg_acquire is an xchg
operation where the load takes on ACQUIRE semantics.

Cc: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Signed-off-by: Will Deacon <will.deacon@arm.com>
---
 Documentation/memory-barriers.txt | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/Documentation/memory-barriers.txt b/Documentation/memory-barriers.txt
index 3729cbe60e41..05f8011011be 100644
--- a/Documentation/memory-barriers.txt
+++ b/Documentation/memory-barriers.txt
@@ -464,6 +464,11 @@ And a couple of implicit varieties:
      This means that ACQUIRE acts as a minimal "acquire" operation and
      RELEASE acts as a minimal "release" operation.
 
+A subset of the atomic operations described in atomic_ops.txt have ACQUIRE
+and RELEASE variants in addition to fully-ordered and relaxed (no barrier
+semantics) definitions.  For compound atomics performing both a load and a
+store, ACQUIRE semantics apply only to the load and RELEASE semantics apply
+only to the store portion of the operation.
 
 Memory barriers are only required where there's a possibility of interaction
 between two CPUs or between a CPU and a device.  If it can be guaranteed that
-- 
2.1.4

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] documentation: ACQUIRE applies to loads, RELEASE applies to stores
  2016-04-22 10:41 [PATCH] documentation: ACQUIRE applies to loads, RELEASE applies to stores Will Deacon
@ 2016-04-22 14:32 ` Peter Zijlstra
  2016-04-22 17:14   ` Paul E. McKenney
  0 siblings, 1 reply; 3+ messages in thread
From: Peter Zijlstra @ 2016-04-22 14:32 UTC (permalink / raw)
  To: Will Deacon; +Cc: linux-kernel, Paul E. McKenney

On Fri, Apr 22, 2016 at 11:41:49AM +0100, Will Deacon wrote:
> For compound atomics performing both a load and a store operation, make
> it clear that _acquire and _release variants refer only to the load and
> store portions of compound atomic. For example, xchg_acquire is an xchg
> operation where the load takes on ACQUIRE semantics.
> 
> Cc: Paul E. McKenney <paulmck@linux.vnet.ibm.com>

Thanks!

Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org>

> Signed-off-by: Will Deacon <will.deacon@arm.com>
> ---
>  Documentation/memory-barriers.txt | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/Documentation/memory-barriers.txt b/Documentation/memory-barriers.txt
> index 3729cbe60e41..05f8011011be 100644
> --- a/Documentation/memory-barriers.txt
> +++ b/Documentation/memory-barriers.txt
> @@ -464,6 +464,11 @@ And a couple of implicit varieties:
>       This means that ACQUIRE acts as a minimal "acquire" operation and
>       RELEASE acts as a minimal "release" operation.
>  
> +A subset of the atomic operations described in atomic_ops.txt have ACQUIRE
> +and RELEASE variants in addition to fully-ordered and relaxed (no barrier
> +semantics) definitions.  For compound atomics performing both a load and a
> +store, ACQUIRE semantics apply only to the load and RELEASE semantics apply
> +only to the store portion of the operation.
>  
>  Memory barriers are only required where there's a possibility of interaction
>  between two CPUs or between a CPU and a device.  If it can be guaranteed that
> -- 
> 2.1.4
> 

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] documentation: ACQUIRE applies to loads, RELEASE applies to stores
  2016-04-22 14:32 ` Peter Zijlstra
@ 2016-04-22 17:14   ` Paul E. McKenney
  0 siblings, 0 replies; 3+ messages in thread
From: Paul E. McKenney @ 2016-04-22 17:14 UTC (permalink / raw)
  To: Peter Zijlstra; +Cc: Will Deacon, linux-kernel

On Fri, Apr 22, 2016 at 04:32:22PM +0200, Peter Zijlstra wrote:
> On Fri, Apr 22, 2016 at 11:41:49AM +0100, Will Deacon wrote:
> > For compound atomics performing both a load and a store operation, make
> > it clear that _acquire and _release variants refer only to the load and
> > store portions of compound atomic. For example, xchg_acquire is an xchg
> > operation where the load takes on ACQUIRE semantics.
> > 
> > Cc: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
> 
> Thanks!
> 
> Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org>

Queued, thank you both!

							Thanx, Paul

> > Signed-off-by: Will Deacon <will.deacon@arm.com>
> > ---
> >  Documentation/memory-barriers.txt | 5 +++++
> >  1 file changed, 5 insertions(+)
> > 
> > diff --git a/Documentation/memory-barriers.txt b/Documentation/memory-barriers.txt
> > index 3729cbe60e41..05f8011011be 100644
> > --- a/Documentation/memory-barriers.txt
> > +++ b/Documentation/memory-barriers.txt
> > @@ -464,6 +464,11 @@ And a couple of implicit varieties:
> >       This means that ACQUIRE acts as a minimal "acquire" operation and
> >       RELEASE acts as a minimal "release" operation.
> >  
> > +A subset of the atomic operations described in atomic_ops.txt have ACQUIRE
> > +and RELEASE variants in addition to fully-ordered and relaxed (no barrier
> > +semantics) definitions.  For compound atomics performing both a load and a
> > +store, ACQUIRE semantics apply only to the load and RELEASE semantics apply
> > +only to the store portion of the operation.
> >  
> >  Memory barriers are only required where there's a possibility of interaction
> >  between two CPUs or between a CPU and a device.  If it can be guaranteed that
> > -- 
> > 2.1.4
> > 
> 

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2016-04-22 17:13 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-04-22 10:41 [PATCH] documentation: ACQUIRE applies to loads, RELEASE applies to stores Will Deacon
2016-04-22 14:32 ` Peter Zijlstra
2016-04-22 17:14   ` Paul E. McKenney

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox