From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932387AbcDVPsY (ORCPT ); Fri, 22 Apr 2016 11:48:24 -0400 Received: from mailapp01.imgtec.com ([195.59.15.196]:35545 "EHLO mailapp01.imgtec.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754209AbcDVPsV (ORCPT ); Fri, 22 Apr 2016 11:48:21 -0400 Date: Fri, 22 Apr 2016 16:48:17 +0100 From: Matt Redfearn To: Thomas Gleixner CC: , , , , , , , Qais Yousef Subject: Re: [PATCH 2/2] genirq: Add error code reporting to irq_{reserve,destroy}_ipi Message-ID: <20160422154816.GA10886@mredfearn-linux> References: <1461338809-10590-1-git-send-email-matt.redfearn@imgtec.com> <1461338809-10590-2-git-send-email-matt.redfearn@imgtec.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) X-Originating-IP: [192.168.154.116] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Apr 22, 2016 at 05:35:46PM +0200, Thomas Gleixner wrote: > On Fri, 22 Apr 2016, Matt Redfearn wrote: > > > Make these functions return appropriate error codes when something goes > > wrong. > > And the reason for this change is? Hi Thomas, Mainly for irq_destroy_ipi, where the first patch in the set makes it possible for the request to fail. But in general with both of these functions it is possible for them to silently fail without giving the caller any idication if inapropriate arguments are passed. Thanks, Matt