From: Alexandre Belloni <alexandre.belloni@free-electrons.com>
To: "Mylène Josserand" <mylene.josserand@free-electrons.com>
Cc: rtc-linux@googlegroups.com,
Alessandro Zummo <a.zummo@towertech.it>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/6] rtc: rv3029: Removes some checks and warnings
Date: Sat, 23 Apr 2016 01:29:46 +0200 [thread overview]
Message-ID: <20160422232946.GF17051@piout.net> (raw)
In-Reply-To: <f4a0b6a1f25057a2d8685dadb0eef5bb0968cf6a.1461250479.git.mylene.josserand@free-electrons.com>
Hi,
On 21/04/2016 at 20:24:17 +0200, Mylène Josserand wrote :
> @@ -829,8 +829,6 @@ static void rv3029_unregister_driver(void)
>
> static int rv3049_probe(struct spi_device *spi)
> {
> - int res;
> - unsigned int tmp;
Well, you just introduced those variables in the previous patch.
> static const struct regmap_config config = {
> .reg_bits = 8,
> .val_bits = 8,
> --
> 2.8.0.rc3
>
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2016-04-22 23:30 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-21 18:24 [PATCH 0/6] add support for Microcrystal RV-3049 Mylène Josserand
2016-04-21 18:24 ` [PATCH 1/6] rtc: rv3029: remove 'i2c' in functions names Mylène Josserand
2016-04-21 18:24 ` [PATCH 2/6] rtc: rv3029: convert to use regmap Mylène Josserand
2016-04-21 18:24 ` [PATCH 3/6] rtc: rv3029: Add support of RV3049 Mylène Josserand
2016-04-21 18:24 ` [PATCH 4/6] rtc: rv3029: Removes some checks and warnings Mylène Josserand
2016-04-22 23:29 ` Alexandre Belloni [this message]
2016-04-22 23:31 ` Alexandre Belloni
2016-04-21 18:24 ` [PATCH 5/6] rtc: rv3029: enable AE_x bits on set_alarm Mylène Josserand
2016-04-22 23:37 ` Alexandre Belloni
2016-04-21 18:24 ` [PATCH 6/6] rtc: rv3029: add alarm IRQ Mylène Josserand
2016-04-22 23:48 ` Alexandre Belloni
2016-04-28 22:00 ` [PATCH V2 0/6] add support for Microcrystal RV-3049 Mylène Josserand
2016-04-28 22:00 ` [PATCH V2 1/6] rtc: rv3029: remove 'i2c' in functions names Mylène Josserand
2016-04-28 22:00 ` [PATCH V2 2/6] rtc: rv3029: convert to use regmap Mylène Josserand
2016-04-28 22:00 ` [PATCH V2 3/6] rtc: rv3029: Add support of RV3049 Mylène Josserand
2016-04-28 22:00 ` [PATCH V2 4/6] rtc: rv3029: Removes some checks and warnings Mylène Josserand
2016-04-28 22:00 ` [PATCH V2 5/6] rtc: rv3029: fix alarm support Mylène Josserand
2016-05-03 8:25 ` Alexandre Belloni
2016-04-28 22:00 ` [PATCH V2 6/6] rtc: rv3029: add alarm IRQ Mylène Josserand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160422232946.GF17051@piout.net \
--to=alexandre.belloni@free-electrons.com \
--cc=a.zummo@towertech.it \
--cc=linux-kernel@vger.kernel.org \
--cc=mylene.josserand@free-electrons.com \
--cc=rtc-linux@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox