Re: [PATCH] ARM64: dts: rockchip: add core dtsi file for RK3399 SoCs

Mark Rutland
2016-04-21T10:19:57Z

On Thu, Apr 21, 2016 at 11:58:12AM +0800, Jianqun Xu wrote:
> + cpu_l0: cpu@0 {
> + device_type = "cpu";
> + compatible = "arm,cortex-a53", "arm,armv8";
> + reg = <0x0 0x0>;
> + enable-method = "psci";
> + #cooling-cells = <2>; /* min followed by max */
> + clocks = <&cru ARMCLKL>;
> + };

> + cpu_b0: cpu@100 {
> + device_type = "cpu";
> + compatible = "arm,cortex-a72", "arm,armv8";
> + reg = <0x0 0x100>;
> + enable-method = "psci";
> + #cooling-cells = <2>; /* min followed by max */
> + clocks = <&cru ARMCLKB>;
> + };

> +
> + arm-pmu {
> + compatible = "arm,armv8-pmuv3";
> + interrupts = <GIC_PPI 7 IRQ_TYPE_LEVEL_LOW>;
> + };

This is wrong, and must go. There should be a separate node for the PMU
of each microarchitecture, with the appropriate compatible string to
represent that (see the juno dts).

In this case things are messier as the same PPI number is being used
across clusters. Marc (Cc'd) has been working on PPI partitions, which
should allow us to support that.

Thanks,
Mark.