From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932181AbcDYLAY (ORCPT ); Mon, 25 Apr 2016 07:00:24 -0400 Received: from mail-wm0-f42.google.com ([74.125.82.42]:37744 "EHLO mail-wm0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754315AbcDYLAW (ORCPT ); Mon, 25 Apr 2016 07:00:22 -0400 Date: Mon, 25 Apr 2016 12:00:21 +0100 From: Lee Jones To: Dan Carpenter Cc: patches@opensource.wolfsonmicro.com, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Mark Brown , Charles Keepax Subject: Re: [patch v2] mfd: wm8400-core: delete wm8400_reg_read() Message-ID: <20160425110021.GD2713@dell> References: <20160414100135.GS31814@localhost.localdomain> <20160415144418.GA8953@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20160415144418.GA8953@mwanda> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 15 Apr 2016, Dan Carpenter wrote: > There was a static checker warning in wm8400_reg_read() because we were > returning u16 and that can't hold the negative error codes. The > function isn't used, so let's just delete it. > > Signed-off-by: Dan Carpenter > --- > v2: just delete the function No diff? I've fixed the $SUBJECT line and applied the patch. > diff --git a/include/linux/mfd/wm8400-private.h b/include/linux/mfd/wm8400-private.h > index 2de565b..4ee908f 100644 > --- a/include/linux/mfd/wm8400-private.h > +++ b/include/linux/mfd/wm8400-private.h > @@ -923,7 +923,6 @@ struct wm8400 { > #define WM8400_LINE_CMP_VTHD_SHIFT 0 /* LINE_CMP_VTHD - [3:0] */ > #define WM8400_LINE_CMP_VTHD_WIDTH 4 /* LINE_CMP_VTHD - [3:0] */ > > -u16 wm8400_reg_read(struct wm8400 *wm8400, u8 reg); > int wm8400_block_read(struct wm8400 *wm8400, u8 reg, int count, u16 *data); > > static inline int wm8400_set_bits(struct wm8400 *wm8400, u8 reg, > diff --git a/drivers/mfd/wm8400-core.c b/drivers/mfd/wm8400-core.c > index 3bd44a4..c1adfc1 100644 > --- a/drivers/mfd/wm8400-core.c > +++ b/drivers/mfd/wm8400-core.c > @@ -35,27 +35,6 @@ static bool wm8400_volatile(struct device *dev, unsigned int reg) > } > } > > -/** > - * wm8400_reg_read - Single register read > - * > - * @wm8400: Pointer to wm8400 control structure > - * @reg: Register to read > - * > - * @return Read value > - */ > -u16 wm8400_reg_read(struct wm8400 *wm8400, u8 reg) > -{ > - unsigned int val; > - int ret; > - > - ret = regmap_read(wm8400->regmap, reg, &val); > - if (ret < 0) > - return ret; > - > - return val; > -} > -EXPORT_SYMBOL_GPL(wm8400_reg_read); > - > int wm8400_block_read(struct wm8400 *wm8400, u8 reg, int count, u16 *data) > { > return regmap_bulk_read(wm8400->regmap, reg, data, count); -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog